===================================================================
RCS file: /cvs/docbook2mdoc/docbook2mdoc.c,v
retrieving revision 1.103
retrieving revision 1.109
diff -u -p -r1.103 -r1.109
--- docbook2mdoc/docbook2mdoc.c	2019/04/11 04:23:22	1.103
+++ docbook2mdoc/docbook2mdoc.c	2019/04/12 10:34:48	1.109
@@ -1,4 +1,4 @@
-/* $Id: docbook2mdoc.c,v 1.103 2019/04/11 04:23:22 schwarze Exp $ */
+/* $Id: docbook2mdoc.c,v 1.109 2019/04/12 10:34:48 schwarze Exp $ */
 /*
  * Copyright (c) 2014 Kristaps Dzonsons <kristaps@bsd.lv>
  * Copyright (c) 2019 Ingo Schwarze <schwarze@openbsd.org>
@@ -38,11 +38,10 @@ pnode_printtext(struct format *f, struct pnode *n)
 	struct pnode	*nn;
 	char		*cp;
 	int		 accept_arg;
-	char		 last;
 
 	cp = n->b;
 	accept_arg = f->flags & FMT_ARG;
-	if (f->linestate == LINE_MACRO && n->spc == 0 && !accept_arg) {
+	if (f->linestate == LINE_MACRO && !n->spc && !accept_arg) {
 		for (;;) {
 			if (*cp == '\0')
 				return;
@@ -80,27 +79,28 @@ pnode_printtext(struct format *f, struct pnode *n)
 	}
 
 	switch (f->linestate) {
+	case LINE_NEW:
+		break;
 	case LINE_TEXT:
-		if (n->spc)
-			putchar(' ');
-		last = ' ';
+		if (n->spc) {
+			if (n->node == NODE_TEXT)
+				macro_close(f);
+			else
+				putchar(' ');
+		}
 		break;
 	case LINE_MACRO:
-		if (accept_arg) {
+		if (accept_arg)
 			putchar(' ');
-			last = ' ';
-			break;
-		}
-		macro_close(f);
-		/* FALLTHROUGH */
-	case LINE_NEW:
-		f->linestate = LINE_TEXT;
-		last = '\n';
+		else
+			macro_close(f);
 		break;
 	}
 
 	if (n->node == NODE_ESCAPE) {
 		fputs(n->b, stdout);
+		if (f->linestate == LINE_NEW)
+			f->linestate = LINE_TEXT;
 		return;
 	}
 
@@ -112,23 +112,10 @@ pnode_printtext(struct format *f, struct pnode *n)
 	if (n->parent != NULL && n->parent->node == NODE_OPTION && *cp == '-')
 		cp++;
 
-	/*
-	 * Print the text, skipping whitespace on new lines,
-	 * escaping control characters on new lines,
-	 * and escaping backslashes.
-	 */
-
-	for (; *cp != '\0'; cp++) {
-		if (last == '\n') {
-			if (isspace((unsigned char)*cp))
-				continue;
-			if (*cp == '\'' || *cp == '.')
-				fputs("\\&", stdout);
-		}
-		putchar(last = *cp);
-		if (last == '\\')
-			putchar('e');
-	}
+	if (f->linestate == LINE_MACRO)
+		macro_addarg(f, cp, 0);
+	else
+		print_text(f, cp, 0);
 }
 
 static void
@@ -586,24 +573,34 @@ pnode_printauthor(struct format *f, struct pnode *n)
 static void
 pnode_printlink(struct format *f, struct pnode *n)
 {
+	struct pnode	*nc;
 	const char	*uri, *text;
 
 	uri = pnode_getattr_raw(n, ATTRKEY_LINKEND, NULL);
 	if (uri != NULL) {
 		if (TAILQ_FIRST(&n->childq) != NULL) {
-			print_textnode(f, n);
+			TAILQ_FOREACH(nc, &n->childq, child)
+				pnode_print(f, nc);
 			text = "";
-		} else {
-			text = pnode_getattr_raw(n, ATTRKEY_ENDTERM, NULL);
-			if (text != NULL)
+		} else if ((text = pnode_getattr_raw(n,
+		    ATTRKEY_ENDTERM, NULL)) != NULL) {
+			if (f->linestate == LINE_MACRO && f->flags & FMT_ARG)
+				macro_addarg(f, text, ARG_SPACE);
+			else
 				print_text(f, text, ARG_SPACE);
 		}
 		if (text != NULL) {
-			macro_open(f, "Pq");
-			f->flags |= FMT_CHILD;
+			if (f->flags & FMT_IMPL)
+				macro_open(f, "Po");
+			else {
+				macro_open(f, "Pq");
+				f->flags |= FMT_CHILD;
+			}
 		}
 		macro_open(f, "Sx");
 		macro_addarg(f, uri, ARG_SPACE);
+		if (text != NULL && f->flags & FMT_IMPL)
+			macro_open(f, "Pc");
 		pnode_unlinksub(n);
 		return;
 	}
@@ -654,25 +651,36 @@ pnode_printprologue(struct format *f, struct ptree *tr
 static void
 pnode_printvarlistentry(struct format *f, struct pnode *n)
 {
-	struct pnode	*nc;
+	struct pnode	*nc, *nn;
 	int		 first = 1;
 
-	macro_close(f);
 	macro_open(f, "It");
 	f->flags |= FMT_IMPL;
-	TAILQ_FOREACH(nc, &n->childq, child) {
+	TAILQ_FOREACH_SAFE(nc, &n->childq, child, nn) {
 		if (nc->node != NODE_TERM && nc->node != NODE_GLOSSTERM)
 			continue;
-		if ( ! first)
-			macro_addarg(f, ",", 0);
+		if (first == 0) {
+			switch (f->linestate) {
+			case LINE_NEW:
+				break;
+			case LINE_TEXT:
+				print_text(f, ",", 0);
+				break;
+			case LINE_MACRO:
+				macro_addarg(f, ",", 0);
+				break;
+			}
+		}
 		pnode_print(f, nc);
+		pnode_unlink(nc);
 		first = 0;
 	}
 	macro_close(f);
-	TAILQ_FOREACH(nc, &n->childq, child)
-		if (nc->node != NODE_TERM && nc->node != NODE_GLOSSTERM)
-			pnode_print(f, nc);
-	pnode_unlinksub(n);
+	while ((nc = TAILQ_FIRST(&n->childq)) != NULL) {
+		pnode_print(f, nc);
+		pnode_unlink(nc);
+	}
+	macro_close(f);
 }
 
 static void
@@ -908,6 +916,9 @@ pnode_print(struct format *f, struct pnode *n)
 		macro_argline(f, "Bd", pnode_getattr(n, ATTRKEY_CLASS) ==
 		    ATTRVAL_MONOSPACED ? "-literal" : "-unfilled");
 		break;
+	case NODE_MARKUP:
+		macro_open(f, "Ic");
+		break;
 	case NODE_MML_MFENCED:
 		pnode_printmathfenced(f, n);
 		break;
@@ -935,7 +946,9 @@ pnode_print(struct format *f, struct pnode *n)
 		break;
 	case NODE_PARAMDEF:
 	case NODE_PARAMETER:
-		macro_nodeline(f, "Fa", n, ARG_SINGLE);
+		/* More often, these appear inside NODE_FUNCPROTOTYPE. */
+		macro_open(f, "Fa");
+		macro_addnode(f, n, ARG_SPACE | ARG_SINGLE);
 		pnode_unlinksub(n);
 		break;
 	case NODE_QUOTE:
@@ -980,9 +993,6 @@ pnode_print(struct format *f, struct pnode *n)
 		break;
 	case NODE_SBR:
 		macro_line(f, "br");
-		break;
-	case NODE_SGMLTAG:
-		macro_open(f, "Ic");
 		break;
 	case NODE_TEXT:
 	case NODE_ESCAPE: