===================================================================
RCS file: /cvs/mandoc/Attic/mlg.c,v
retrieving revision 1.7
retrieving revision 1.21
diff -u -p -r1.7 -r1.21
--- mandoc/Attic/mlg.c	2008/12/04 19:31:57	1.7
+++ mandoc/Attic/mlg.c	2008/12/08 12:46:28	1.21
@@ -1,4 +1,4 @@
-/* $Id: mlg.c,v 1.7 2008/12/04 19:31:57 kristaps Exp $ */
+/* $Id: mlg.c,v 1.21 2008/12/08 12:46:28 kristaps Exp $ */
 /*
  * Copyright (c) 2008 Kristaps Dzonsons <kristaps@kth.se>
  *
@@ -19,6 +19,7 @@
 #include <assert.h>
 #include <ctype.h>
 #include <err.h>
+#include <stdarg.h>
 #include <stdlib.h>
 #include <stdio.h>
 #include <string.h>
@@ -51,54 +52,71 @@ struct	md_mlg {
 	size_t		  pos;
 	enum md_tok	  last;
 	void		 *arg;
-	ml_begintag	  begintag;
-	ml_endtag	  endtag;
-	ml_begin	  begin;
-	ml_end		  end;
+	struct ml_cbs	  cbs;
 	int		  flags;
 #define	ML_OVERRIDE_ONE	 (1 << 0)
 #define	ML_OVERRIDE_ALL	 (1 << 1)
+	void		 *data;
 };
 
-
-static	void		 mlg_roffmsg(void *arg, enum roffmsg, 
-				const char *, const char *, char *);
+static	void		 mlg_roffmsg(void *arg, 
+				enum roffmsg, const char *, 
+				const char *, const char *);
 static	int		 mlg_roffhead(void *, const struct tm *, 
 				const char *, const char *, 
-				const char *, const char *);
+				enum roffmsec, const char *);
 static	int		 mlg_rofftail(void *);
-static	int		 mlg_roffin(void *, int, int *, char **);
+static	int		 mlg_roffin(void *, int, 
+				int *, const char **);
 static	int		 mlg_roffdata(void *, int, 
-				const char *, char *);
+				const char *, const char *);
 static	int		 mlg_roffout(void *, int);
-static	int		 mlg_roffblkin(void *, int, int *, char **);
+static	int		 mlg_roffblkin(void *, int, int *, 
+				const char **);
 static	int		 mlg_roffblkout(void *, int);
-static	int		 mlg_roffspecial(void *, int, int *, 
-				char **, char **);
+static	int		 mlg_roffspecial(void *, int, 
+				const char *, const int *,
+				const char **, const char **);
 static	int		 mlg_roffblkheadin(void *, int, 
-				int *, char **);
+				int *, const char **);
 static	int		 mlg_roffblkheadout(void *, int);
 static	int		 mlg_roffblkbodyin(void *, int, 
-				int *, char **);
+				int *, const char **);
 static	int		 mlg_roffblkbodyout(void *, int);
 
-static	int		 mlg_beginblk(struct md_mlg *, enum md_ns, int, 
-				int *, char **);
-static	int		 mlg_endblk(struct md_mlg *, enum md_ns, int);
+static	int		 mlg_ref_special(struct md_mlg *, int,
+				const char *, const char **);
+static	int		 mlg_formatted_special(struct md_mlg *, 
+				int, const int *, 
+				const char **, const char **);
+static	int		 mlg_literal_special(struct md_mlg *, 
+				int,  const char *, const int *, 
+				const char **, const char **);
+static	int		 mlg_function_special(struct md_mlg *, 
+				const char *, const char **);
+static	int		 mlg_atom_special(struct md_mlg *, int,
+				const char *, const char **);
+
 static	int		 mlg_begintag(struct md_mlg *, enum md_ns, 
-				int, int *, char **);
+				int, int *, const char **);
 static	int		 mlg_endtag(struct md_mlg *, enum md_ns, int);
 static	int	  	 mlg_indent(struct md_mlg *);
 static	int		 mlg_newline(struct md_mlg *);
 static	void		 mlg_mode(struct md_mlg *, enum md_tok);
+static	int		 mlg_nstring(struct md_mlg *, 
+				const char *, const char *, size_t);
+static	int		 mlg_string(struct md_mlg *,
+				const char *, const char *);
 static	int		 mlg_data(struct md_mlg *, int, 
-				const char *, char *);
+				const char *, const char *);
 static	void		 mlg_err(struct md_mlg *, const char *, 
-				const char *, char *);
-static	void		 mlg_warn(struct md_mlg *, const char *, 
-				const char *, char *);
-static	void		 mlg_msg(struct md_mlg *, enum roffmsg, 
-				const char *, const char *, char *);
+				const char *, const char *, ...);
+static	void		 mlg_msg(struct md_mlg *, 
+				enum roffmsg, const char *, 
+				const char *, const char *);
+static	void		 mlg_vmsg(struct md_mlg *, enum roffmsg, 
+				const char *, const char *, 
+				const char *, va_list);
 
 #ifdef __linux__
 extern	size_t		 strlcat(char *, const char *, size_t);
@@ -107,69 +125,67 @@ extern	size_t		 strlcpy(char *, const char *, size_t);
 
 
 static int
-mlg_beginblk(struct md_mlg *p, enum md_ns ns, int tok, 
-		int *argc, char **argv)
+mlg_begintag(struct md_mlg *p, enum md_ns ns, int tok,
+		int *argc, const char **argv)
 {
-	if (0 != p->pos) {
-		if ( ! mlg_newline(p))
-			return(0);
-		if ( ! mlg_indent(p))
-			return(0);
-	} else if ( ! mlg_indent(p))
-		return(0);
+	ssize_t		 res;
 
-	p->indent++;
-	mlg_mode(p, MD_BLK_IN);
+	assert(MD_NS_DEFAULT != ns);
 
-	if ( ! mlg_begintag(p, ns, tok, argc, argv))
-		return(0);
-	return(mlg_newline(p));
-}
-
-
-static int
-mlg_endblk(struct md_mlg *p, enum md_ns ns, int tok)
-{
-
-	p->indent--;
-
-	if (0 != p->pos) {
-		if ( ! mlg_newline(p))
+	switch (ns) {
+	case (MD_NS_INLINE):
+		if ( ! (ML_OVERRIDE_ONE & p->flags) && 
+				! (ML_OVERRIDE_ALL & p->flags) && 
+				p->pos + 11 >= COLUMNS)
+			if ( ! mlg_newline(p))
+				return(0);
+		if (0 != p->pos && (MD_TEXT == p->last || 
+					MD_INLINE_OUT == p->last)
+				&& ! (ML_OVERRIDE_ONE & p->flags)
+				&& ! (ML_OVERRIDE_ALL & p->flags))
+			if ( ! ml_nputs(p->mbuf, " ", 1, &p->pos))
+				return(0);
+		if (0 == p->pos && ! mlg_indent(p))
 			return(0);
-		if ( ! mlg_indent(p))
+		mlg_mode(p, MD_INLINE_IN);
+		break;
+	default:
+		if (0 != p->pos) {
+			if ( ! mlg_newline(p))
+				return(0);
+			if ( ! mlg_indent(p))
+				return(0);
+		} else if ( ! mlg_indent(p))
 			return(0);
-	} else if ( ! mlg_indent(p))
-		return(0);
+		p->indent++;
+		mlg_mode(p, MD_BLK_IN);
+		break;
+	}
 
-	mlg_mode(p, MD_BLK_OUT);
-	if ( ! mlg_endtag(p, ns, tok))
-		return(0);
-	return(mlg_newline(p));
-}
-
-
-static int
-mlg_begintag(struct md_mlg *p, enum md_ns ns, int tok,
-		int *argc, char **argv)
-{
-	ssize_t		 res;
-
-	/* TODO: extra rules for block/inline. */
-
 	if ( ! ml_nputs(p->mbuf, "<", 1, &p->pos))
 		return(0);
 
-	res = (*p->begintag)(p->mbuf, p->args, ns, tok,
-			argc, (const char **)argv);
+	res = (*p->cbs.ml_begintag)(p->mbuf, p->data, 
+			p->args, ns, tok, argc, argv);
 	if (-1 == res)
 		return(0);
 
 	assert(res >= 0);
 	p->pos += (size_t)res;
 
-	/* TODO: extra rules for block/inline. */
+	if ( ! ml_nputs(p->mbuf, ">", 1, &p->pos))
+		return(0);
 
-	return(ml_nputs(p->mbuf, ">", 1, &p->pos));
+	switch (ns) {
+	case (MD_NS_INLINE):
+		break;
+	default:
+		if ( ! mlg_newline(p))
+			return(0);
+		break;
+	}
+
+	return(1);
 }
 
 
@@ -178,21 +194,46 @@ mlg_endtag(struct md_mlg *p, enum md_ns ns, int tok)
 {
 	ssize_t		 res;
 
-	/* TODO: extra rules for block/inline. */
+	assert(MD_NS_DEFAULT != ns);
 
+	switch (ns) {
+	case (MD_NS_INLINE):
+		break;
+	default:
+		p->indent--;
+		if (0 != p->pos) {
+			if ( ! mlg_newline(p))
+				return(0);
+			if ( ! mlg_indent(p))
+				return(0);
+		} else if ( ! mlg_indent(p))
+			return(0);
+		break;
+	}
+
 	if ( ! ml_nputs(p->mbuf, "</", 2, &p->pos))
 		return(0);
 
-	res = (*p->endtag)(p->mbuf, p->args, ns, tok);
+	res = (*p->cbs.ml_endtag)(p->mbuf, p->data, p->args, ns, tok);
 	if (-1 == res)
 		return(0);
 
 	assert(res >= 0);
 	p->pos += (size_t)res;
 
-	/* TODO: extra rules for block/inline. */
+	if ( ! ml_nputs(p->mbuf, ">", 1, &p->pos))
+		return(0);
+	
+	switch (ns) {
+	case (MD_NS_INLINE):
+		mlg_mode(p, MD_INLINE_OUT);
+		break;
+	default:
+		mlg_mode(p, MD_BLK_OUT);
+		break;
+	}
 
-	return(ml_nputs(p->mbuf, ">", 1, &p->pos));
+	return(1);
 }
 
 
@@ -201,7 +242,8 @@ mlg_indent(struct md_mlg *p)
 {
 	size_t		 count;
 
-	count = p->indent > MAXINDENT ? (size_t)MAXINDENT : p->indent;
+	count = p->indent > MAXINDENT ? 
+		(size_t)MAXINDENT : p->indent;
 	count *= INDENT;
 
 	assert(0 == p->pos);
@@ -212,12 +254,9 @@ mlg_indent(struct md_mlg *p)
 static int
 mlg_newline(struct md_mlg *p)
 {
-	size_t		 dummy;
 
-	if ( ! ml_nputs(p->mbuf, "\n", 1, &dummy))
-		return(0);
 	p->pos = 0;
-	return(1);
+	return(ml_nputs(p->mbuf, "\n", 1, NULL));
 }
 
 
@@ -231,86 +270,81 @@ mlg_mode(struct md_mlg *p, enum md_tok ns)
 
 
 static int
-mlg_data(struct md_mlg *p, int space, const char *start, char *buf)
+mlg_string(struct md_mlg *p, const char *start, const char *buf)
 {
-	size_t		 sz;
-	char		*bufp;
+	
+	return(mlg_nstring(p, start, buf, strlen(buf)));
+}
+
+
+static int
+mlg_nstring(struct md_mlg *p, const char *start, 
+		const char *buf, size_t sz)
+{
 	int		 c;
+	ssize_t		 res;
 
 	assert(p->mbuf);
 	assert(0 != p->indent);
 
-	if (ML_OVERRIDE_ONE & p->flags || 
-			ML_OVERRIDE_ALL & p->flags)
-		space = 0;
+	res = (*p->cbs.ml_beginstring)(p->mbuf, p->args, buf, sz);
+	if (-1 == res) 
+		return(0);
 
-	while (*buf) {
-		while (*buf && isspace(*buf))
-			buf++;
+	if (0 == (c = ml_nputstring(p->mbuf, buf, sz, &p->pos))) {
+		mlg_err(p, start, buf, "bad string "
+				"encoding: `%s'", buf);
+		return(0);
+	} else if (-1 == c)
+		return(0);
 
-		if (0 == *buf)
-			break;
+	res = (*p->cbs.ml_endstring)(p->mbuf, p->args, buf, sz);
+	if (-1 == res) 
+		return(0);
 
-		bufp = buf;
-		while (*buf && ! isspace(*buf))
-			buf++;
+	return(1);
+}
 
-		if (0 != *buf)
-			*buf++ = 0;
 
-		sz = strlen(bufp);
+static int
+mlg_data(struct md_mlg *p, int space, 
+		const char *start, const char *buf)
+{
+	size_t		 sz;
 
-		if (0 == p->pos) {
-			if ( ! mlg_indent(p))
-				return(0);
+	assert(p->mbuf);
+	assert(0 != p->indent);
 
-			c = ml_nputstring(p->mbuf, bufp, sz, &p->pos);
-			if (0 == c) {
-				mlg_err(p, start, bufp, "invalid "
-						"character sequence");
-				return(0);
-			} else if (c > 1) {
-				mlg_warn(p, start, bufp, "bogus "
-						"character sequence");
-				return(0);
-			} else if (-1 == c)
-				return(0);
+	if (ML_OVERRIDE_ONE & p->flags || 
+			ML_OVERRIDE_ALL & p->flags)
+		space = 0;
 
-			if (p->indent * INDENT + sz >= COLUMNS)
-				if ( ! mlg_newline(p))
-					return(0);
-			if ( ! (ML_OVERRIDE_ALL & p->flags))
-				space = 1;
-			continue;
-		}
+	sz = strlen(buf);
 
-		if (space && sz + p->pos >= COLUMNS) {
+	if (0 == p->pos) {
+		if ( ! mlg_indent(p))
+			return(0);
+		if ( ! mlg_nstring(p, start, buf, sz))
+			return(0);
+
+		if (p->indent * INDENT + sz >= COLUMNS)
 			if ( ! mlg_newline(p))
 				return(0);
-			if ( ! mlg_indent(p))
-				return(0);
-		} else if (space) {
-			if ( ! ml_nputs(p->mbuf, " ", 1, &p->pos))
-				return(0);
-		}
 
-		c = ml_nputstring(p->mbuf, bufp, sz, &p->pos);
-		if (0 == c) {
-			mlg_err(p, start, bufp, "invalid "
-					"character sequence");
+		return(1);
+	}
+
+	if (space && sz + p->pos >= COLUMNS) {
+		if ( ! mlg_newline(p))
 			return(0);
-		} else if (c > 1) {
-			mlg_warn(p, start, bufp, "bogus "
-					"character sequence");
+		if ( ! mlg_indent(p))
 			return(0);
-		} else if (-1 == c)
+	} else if (space) {
+		if ( ! ml_nputs(p->mbuf, " ", 1, &p->pos))
 			return(0);
-
-		if ( ! (ML_OVERRIDE_ALL & p->flags))
-			space = 1;
 	}
 
-	return(1);
+	return(mlg_nstring(p, start, buf, sz));
 }
 
 
@@ -328,7 +362,10 @@ mlg_exit(struct md_mlg *p, int flush)
 	int		 c;
 
 	c = roff_free(p->tree, flush);
+	(*p->cbs.ml_free)(p->data);
+
 	free(p);
+
 	return(c);
 }
 
@@ -337,8 +374,7 @@ struct md_mlg *
 mlg_alloc(const struct md_args *args, 
 		const struct md_rbuf *rbuf,
 		struct md_mbuf *mbuf, 
-		ml_begintag begintag, ml_endtag endtag,
-		ml_begin begin, ml_end end)
+		const struct ml_cbs *cbs)
 {
 	struct roffcb	 cb;
 	struct md_mlg	*p;
@@ -363,23 +399,23 @@ mlg_alloc(const struct md_args *args, 
 	p->args = args;
 	p->mbuf = mbuf;
 	p->rbuf = rbuf;
-	p->begintag = begintag;
-	p->endtag = endtag;
-	p->begin = begin;
-	p->end = end;
 
-	if (NULL == (p->tree = roff_alloc(&cb, p))) {
+	(void)memcpy(&p->cbs, cbs, sizeof(struct ml_cbs));
+
+	if (NULL == (p->tree = roff_alloc(&cb, p))) 
 		free(p);
-		return(NULL);
-	}
+	else if ( ! (*p->cbs.ml_alloc)(&p->data))
+		free(p);
+	else
+		return(p);
 
-	return(p);
+	return(NULL);
 }
 
 
 static int
 mlg_roffhead(void *arg, const struct tm *tm, const char *os, 
-		const char *title, const char *sec, const char *vol)
+		const char *title, enum roffmsec sec, const char *vol)
 {
 	struct md_mlg	*p;
 
@@ -387,7 +423,8 @@ mlg_roffhead(void *arg, const struct tm *tm, const cha
 	p = (struct md_mlg *)arg;
 
 	mlg_mode(p, MD_BLK_IN);
-	if ( ! (*p->begin)(p->mbuf, p->args, tm, os, title, sec, vol))
+
+	if ( ! (*p->cbs.ml_begin)(p->mbuf, p->args, tm, os, title, sec, vol))
 		return(0);
 
 	p->indent++;
@@ -403,20 +440,162 @@ mlg_rofftail(void *arg)
 	assert(arg);
 	p = (struct md_mlg *)arg;
 
-	if (0 != p->pos && ! mlg_newline(p))
+	if (0 != p->pos)
+		if ( ! mlg_newline(p))
+			return(0);
+
+	if ( ! (*p->cbs.ml_end)(p->mbuf, p->args))
 		return(0);
 
 	mlg_mode(p, MD_BLK_OUT);
-	if ( ! (*p->end)(p->mbuf, p->args))
-		return(0);
 
 	return(mlg_newline(p));
 }
 
 
+static int
+mlg_literal_special(struct md_mlg *p, int tok, const char *start,
+		const int *argc, const char **argv, const char **more)
+{
+	char		 *lit;
+
+	if ( ! mlg_begintag(p, MD_NS_INLINE, tok, NULL, more))
+		return(0);
+
+	/* FIXME: must be ml-filtered. */
+
+	lit = ml_literal(tok, argc, argv, more);
+	assert(lit);
+
+	if ( ! ml_puts(p->mbuf, lit, &p->pos))
+		return(0);
+	while (*more) { 
+		if ( ! ml_nputs(p->mbuf, " ", 1, &p->pos))
+			return(0);
+		if ( ! mlg_string(p, start, *more++))
+			return(0);
+	}
+
+	return(mlg_endtag(p, MD_NS_INLINE, tok));
+}
+
+
+static int
+mlg_ref_special(struct md_mlg *p, int tok,
+		const char *start, const char **more)
+{
+
+	if ( ! mlg_begintag(p, MD_NS_INLINE, tok, NULL, more))
+		return(0);
+
+	assert(*more);
+	if ( ! ml_puts(p->mbuf, *more++, &p->pos))
+		return(0);
+
+	if (*more) {
+		if ( ! ml_nputs(p->mbuf, "(", 1, &p->pos))
+			return(0);
+		if ( ! mlg_string(p, start, *more++))
+			return(0);
+		if ( ! ml_nputs(p->mbuf, ")", 1, &p->pos))
+			return(0);
+	}
+
+	assert(NULL == *more);
+	return(mlg_endtag(p, MD_NS_INLINE, tok));
+}
+
+
+static int
+mlg_formatted_special(struct md_mlg *p, int tok, 
+		const int *argc, const char **argv, const char **more)
+{
+	char		 buf[256], *lit;
+
+	if ( ! mlg_begintag(p, MD_NS_INLINE, tok, NULL, more))
+		return(0);
+
+	/* FIXME: must be ml-filtered. */
+
+	lit = ml_literal(tok, argc, argv, more);
+
+	assert(lit);
+	assert(*more);
+	(void)snprintf(buf, sizeof(buf), lit, *more++);
+	assert(NULL == *more);
+
+	if ( ! ml_puts(p->mbuf, buf, &p->pos))
+		return(0);
+
+	return(mlg_endtag(p, MD_NS_INLINE, tok));
+}
+
+
+static int
+mlg_atom_special(struct md_mlg *p, int tok,
+		const char *start, const char **more)
+{
+
+	if ( ! mlg_begintag(p, MD_NS_INLINE, tok, NULL, more))
+		return(0);
+
+	assert(*more);
+	if ( ! mlg_string(p, start, *more++))
+		return(0);
+
+	assert(NULL == *more);
+	return(mlg_endtag(p, MD_NS_INLINE, tok));
+}
+
+
+static int
+mlg_function_special(struct md_mlg *p, 
+		const char *start, const char **more)
+{
+
+	assert(*more);
+
+	if ( ! mlg_begintag(p, MD_NS_INLINE, ROFF_Fn, NULL, more))
+		return(0);
+	if ( ! mlg_string(p, start, *more++))
+		return(0);
+	if ( ! mlg_endtag(p, MD_NS_INLINE, ROFF_Fn))
+		return(0);
+
+	if (NULL == *more)
+		return(1);
+
+	if ( ! ml_nputs(p->mbuf, "(", 1, &p->pos))
+		return(0);
+
+	p->flags |= ML_OVERRIDE_ONE;
+
+	if ( ! mlg_begintag(p, MD_NS_INLINE, ROFF_Fa, NULL, more))
+		return(0);
+	if ( ! mlg_string(p, start, *more++))
+		return(0);
+	if ( ! mlg_endtag(p, MD_NS_INLINE, ROFF_Fa))
+		return(0);
+
+	while (*more) {
+		if ( ! ml_nputs(p->mbuf, ", ", 2, &p->pos))
+			return(0);
+		if ( ! mlg_begintag(p, MD_NS_INLINE, ROFF_Fa, NULL, more))
+			return(0);
+		if ( ! mlg_string(p, start, *more++))
+			return(0);
+		if ( ! mlg_endtag(p, MD_NS_INLINE, ROFF_Fa))
+			return(0);
+	}
+
+	return(ml_nputs(p->mbuf, ")", 1, &p->pos));
+}
+
+
 /* ARGSUSED */
 static int
-mlg_roffspecial(void *arg, int tok, int *argc, char **argv, char **more)
+mlg_roffspecial(void *arg, int tok, const char *start, 
+		const int *argc, const char **argv, const char **more)
 {
 	struct md_mlg	*p;
 
@@ -426,27 +605,72 @@ mlg_roffspecial(void *arg, int tok, int *argc, char **
 	switch (tok) {
 	case (ROFF_Ns):
 		p->flags |= ML_OVERRIDE_ONE;
-		break;
+		return(1);
+
 	case (ROFF_Sm):
 		assert(*more);
 		if (0 == strcmp(*more, "on"))
 			p->flags |= ML_OVERRIDE_ALL;
 		else
 			p->flags &= ~ML_OVERRIDE_ALL;
-		break;
+		return(1);
+
+	case (ROFF_Fn):
+		return(mlg_function_special(p, start, more));
+
+	case (ROFF_Xr):
+		return(mlg_ref_special(p, tok, start, more));
+ 
+	case (ROFF_Sx): /* FIXME */
+		/* FALLTHROUGH */
+	case (ROFF_Nm):
+		return(mlg_atom_special(p, tok, start, more));
+	
+	case (ROFF_In):
+		/* NOTREACHED */
+	case (ROFF_Ex):
+		/* NOTREACHED */
+	case (ROFF_Rv):
+		return(mlg_formatted_special(p, tok, 
+					argc, argv, more));
+
+	case (ROFF_At):
+		/* FALLTHROUGH */
+	case (ROFF_Bt):
+		/* FALLTHROUGH */
+	case (ROFF_Ud):
+		/* FALLTHROUGH */
+	case (ROFF_Ux):
+		/* FALLTHROUGH */
+	case (ROFF_Bx):
+		/* FALLTHROUGH */
+	case (ROFF_Bsx):
+		/* FALLTHROUGH */
+	case (ROFF_Fx):
+		/* FALLTHROUGH */
+	case (ROFF_Nx):
+		/* FALLTHROUGH */
+	case (ROFF_St):
+		/* FALLTHROUGH */
+	case (ROFF_Ox):
+		return(mlg_literal_special(p, tok, start, 
+					argc, argv, more));
 	default:
 		break;
 	}
 
-	return(1);
+	mlg_err(p, start, start, "`%s' not yet supported", 
+			toknames[tok]);
+	return(0);
 }
 
 
 static int
-mlg_roffblkin(void *arg, int tok, int *argc, char **argv)
+mlg_roffblkin(void *arg, int tok, 
+		int *argc, const char **argv)
 {
 
-	return(mlg_beginblk((struct md_mlg *)arg, 
+	return(mlg_begintag((struct md_mlg *)arg, 
 				MD_NS_BLOCK, tok, argc, argv));
 }
 
@@ -455,15 +679,16 @@ static int
 mlg_roffblkout(void *arg, int tok)
 {
 
-	return(mlg_endblk((struct md_mlg *)arg, MD_NS_BLOCK, tok));
+	return(mlg_endtag((struct md_mlg *)arg, MD_NS_BLOCK, tok));
 }
 
 
 static int
-mlg_roffblkbodyin(void *arg, int tok, int *argc, char **argv)
+mlg_roffblkbodyin(void *arg, int tok, 
+		int *argc, const char **argv)
 {
 
-	return(mlg_beginblk((struct md_mlg *)arg, 
+	return(mlg_begintag((struct md_mlg *)arg, 
 				MD_NS_BODY, tok, argc, argv));
 }
 
@@ -472,15 +697,16 @@ static int
 mlg_roffblkbodyout(void *arg, int tok)
 {
 
-	return(mlg_endblk((struct md_mlg *)arg, MD_NS_BODY, tok));
+	return(mlg_endtag((struct md_mlg *)arg, MD_NS_BODY, tok));
 }
 
 
 static int
-mlg_roffblkheadin(void *arg, int tok, int *argc, char **argv)
+mlg_roffblkheadin(void *arg, int tok, 
+		int *argc, const char **argv)
 {
 
-	return(mlg_beginblk((struct md_mlg *)arg, 
+	return(mlg_begintag((struct md_mlg *)arg, 
 				MD_NS_HEAD, tok, argc, argv));
 }
 
@@ -489,60 +715,30 @@ static int
 mlg_roffblkheadout(void *arg, int tok)
 {
 
-	return(mlg_endblk((struct md_mlg *)arg, MD_NS_HEAD, tok));
+	return(mlg_endtag((struct md_mlg *)arg, MD_NS_HEAD, tok));
 }
 
 
 static int
-mlg_roffin(void *arg, int tok, int *argc, char **argv)
+mlg_roffin(void *arg, int tok, int *argc, const char **argv)
 {
-	struct md_mlg	*p;
 
-	assert(arg);
-	p = (struct md_mlg *)arg;
-
-	/* FIXME: this part. */
-
-	if ( ! (ML_OVERRIDE_ONE & p->flags) && 
-			! (ML_OVERRIDE_ALL & p->flags) && 
-			p->pos + 11 > COLUMNS) 
-		if ( ! mlg_newline(p))
-			return(0);
-
-	if (0 != p->pos && (MD_TEXT == p->last || 
-				MD_INLINE_OUT == p->last)
-			&& ! (ML_OVERRIDE_ONE & p->flags)
-			&& ! (ML_OVERRIDE_ALL & p->flags))
-		if ( ! ml_nputs(p->mbuf, " ", 1, &p->pos))
-			return(0);
-
-	if (0 == p->pos && ! mlg_indent(p))
-		return(0);
-
-	mlg_mode(p, MD_INLINE_IN);
-	return(mlg_begintag(p, MD_NS_INLINE, tok, argc, argv));
+	return(mlg_begintag((struct md_mlg *)arg, 
+				MD_NS_INLINE, tok, argc, argv));
 }
 
 
 static int
 mlg_roffout(void *arg, int tok)
 {
-	struct md_mlg	*p;
 
-	assert(arg);
-	p = (struct md_mlg *)arg;
-
-	if (0 == p->pos && ! mlg_indent(p))
-		return(0);
-
-	mlg_mode(p, MD_INLINE_OUT);
-	return(mlg_endtag(p, MD_NS_INLINE, tok));
+	return(mlg_endtag((struct md_mlg *)arg, MD_NS_INLINE, tok));
 }
 
 
 static void
-mlg_roffmsg(void *arg, enum roffmsg lvl, 
-		const char *buf, const char *pos, char *msg)
+mlg_roffmsg(void *arg, enum roffmsg lvl, const char *buf, 
+		const char *pos, const char *msg)
 {
 
 	mlg_msg((struct md_mlg *)arg, lvl, buf, pos, msg);
@@ -550,7 +746,8 @@ mlg_roffmsg(void *arg, enum roffmsg lvl, 
 
 
 static int
-mlg_roffdata(void *arg, int space, const char *start, char *buf)
+mlg_roffdata(void *arg, int space, 
+		const char *start, const char *buf)
 {
 	struct md_mlg	*p;
 
@@ -566,24 +763,31 @@ mlg_roffdata(void *arg, int space, const char *start, 
 
 
 static void
-mlg_err(struct md_mlg *p, const char *buf, const char *pos, char *msg)
+mlg_vmsg(struct md_mlg *p, enum roffmsg lvl, const char *start, 
+		const char *pos, const char *fmt, va_list ap)
 {
+	char		 buf[128];
 
-	mlg_msg(p, ROFF_ERROR, buf, pos, msg);
+	(void)vsnprintf(buf, sizeof(buf), fmt, ap);
+	mlg_msg(p, lvl, start, pos, buf);
 }
 
 
 static void
-mlg_warn(struct md_mlg *p, const char *buf, const char *pos, char *msg)
+mlg_err(struct md_mlg *p, const char *start, 
+		const char *pos, const char *fmt, ...)
 {
+	va_list		 ap;
 
-	mlg_msg(p, ROFF_WARN, buf, pos, msg);
+	va_start(ap, fmt);
+	mlg_vmsg(p, ROFF_ERROR, start, pos, fmt, ap);
+	va_end(ap);
 }
 
 
 static void
 mlg_msg(struct md_mlg *p, enum roffmsg lvl, 
-		const char *buf, const char *pos, char *msg)
+		const char *buf, const char *pos, const char *msg)
 {
 	char		*level;
 
@@ -607,5 +811,4 @@ mlg_msg(struct md_mlg *p, enum roffmsg lvl, 
 	else
 		(void)fprintf(stderr, "%s: %s: %s\n", 
 				p->rbuf->name, level, msg);
-
 }