=================================================================== RCS file: /cvs/mandoc/cgi.c,v retrieving revision 1.86 retrieving revision 1.90 diff -u -p -r1.86 -r1.90 --- mandoc/cgi.c 2014/07/25 17:34:06 1.86 +++ mandoc/cgi.c 2014/07/25 20:09:09 1.90 @@ -1,4 +1,4 @@ -/* $Id: cgi.c,v 1.86 2014/07/25 17:34:06 schwarze Exp $ */ +/* $Id: cgi.c,v 1.90 2014/07/25 20:09:09 schwarze Exp $ */ /* * Copyright (c) 2011, 2012 Kristaps Dzonsons * Copyright (c) 2014 Ingo Schwarze @@ -148,10 +148,12 @@ static void http_printquery(const struct req *req) { - if (NULL != req->q.manpath) { - printf("&manpath="); - http_print(req->q.manpath); + if (NULL != req->q.query) { + printf("query="); + http_print(req->q.query); } + if (0 == req->q.equal) + printf("&apropos=1"); if (NULL != req->q.sec) { printf("&sec="); http_print(req->q.sec); @@ -160,22 +162,23 @@ http_printquery(const struct req *req) printf("&arch="); http_print(req->q.arch); } - if (NULL != req->q.query) { - printf("&query="); - http_print(req->q.query); + if (NULL != req->q.manpath && + strcmp(req->q.manpath, req->p[0])) { + printf("&manpath="); + http_print(req->q.manpath); } - if (0 == req->q.equal) - printf("&apropos=1"); } static void html_printquery(const struct req *req) { - if (NULL != req->q.manpath) { - printf("&manpath="); - html_print(req->q.manpath); + if (NULL != req->q.query) { + printf("query="); + html_print(req->q.query); } + if (0 == req->q.equal) + printf("&apropos=1"); if (NULL != req->q.sec) { printf("&sec="); html_print(req->q.sec); @@ -184,12 +187,11 @@ html_printquery(const struct req *req) printf("&arch="); html_print(req->q.arch); } - if (NULL != req->q.query) { - printf("&query="); - html_print(req->q.query); + if (NULL != req->q.manpath && + strcmp(req->q.manpath, req->p[0])) { + printf("&manpath="); + html_print(req->q.manpath); } - if (0 == req->q.equal) - printf("&apropos=1"); } static void @@ -849,12 +851,13 @@ static void format(const struct req *req, const char *file) { struct mparse *mp; - int fd; struct mdoc *mdoc; struct man *man; void *vp; + char *opts; enum mandoclevel rc; - char opts[PATH_MAX + 128]; + int fd; + int usepath; if (-1 == (fd = open(file, O_RDONLY, 0))) { puts("

You specified an invalid manual file.

"); @@ -873,10 +876,14 @@ format(const struct req *req, const char *file) return; } - snprintf(opts, sizeof(opts), "fragment,man=%s?" - "manpath=%s&query=%%N&sec=%%S&arch=%s", - scriptname, req->q.manpath, - req->q.arch ? req->q.arch : ""); + usepath = strcmp(req->q.manpath, req->p[0]); + mandoc_asprintf(&opts, + "fragment,man=%s?query=%%N&sec=%%S%s%s%s%s", + scriptname, + req->q.arch ? "&arch=" : "", + req->q.arch ? req->q.arch : "", + usepath ? "&manpath=" : "", + usepath ? req->q.manpath : ""); mparse_result(mp, &mdoc, &man, NULL); if (NULL == man && NULL == mdoc) { @@ -896,6 +903,7 @@ format(const struct req *req, const char *file) html_free(vp); mparse_free(mp); + free(opts); } static void @@ -1083,7 +1091,8 @@ main(void) if (NULL != (querystring = getenv("QUERY_STRING"))) http_parse(&req, querystring); - if ( ! validate_manpath(&req, req.q.manpath)) { + if ( ! (NULL == req.q.manpath || + validate_manpath(&req, req.q.manpath))) { pg_error_badrequest( "You specified an invalid manpath."); return(EXIT_FAILURE);