=================================================================== RCS file: /cvs/mandoc/mdoc_argv.c,v retrieving revision 1.7 retrieving revision 1.24 diff -u -p -r1.7 -r1.24 --- mandoc/mdoc_argv.c 2009/06/17 14:08:47 1.7 +++ mandoc/mdoc_argv.c 2009/08/20 09:07:24 1.24 @@ -1,4 +1,4 @@ -/* $Id: mdoc_argv.c,v 1.7 2009/06/17 14:08:47 kristaps Exp $ */ +/* $Id: mdoc_argv.c,v 1.24 2009/08/20 09:07:24 kristaps Exp $ */ /* * Copyright (c) 2008, 2009 Kristaps Dzonsons * @@ -32,14 +32,6 @@ * There's no limit to the number or arguments that may be allocated. */ -/* FIXME .Bf Li raises "macro-like parameter". */ -/* FIXME .Bl -column should deprecate old-groff syntax. */ - -#define ARGS_QUOTED (1 << 0) -#define ARGS_DELIM (1 << 1) -#define ARGS_TABSEP (1 << 2) -#define ARGS_ARGVLIKE (1 << 3) - #define ARGV_NONE (1 << 0) #define ARGV_SINGLE (1 << 1) #define ARGV_MULTI (1 << 2) @@ -47,19 +39,6 @@ #define MULTI_STEP 5 -enum mwarn { - WQUOTPARM, - WARGVPARM, - WCOLEMPTY, - WTAILWS -}; - -enum merr { - EQUOTTERM, - EMALLOC, - EARGVAL -}; - static int argv_a2arg(int, const char *); static int args(struct mdoc *, int, int *, char *, int, char **); @@ -71,11 +50,7 @@ static int argv_opt_single(struct mdoc *, int, struct mdoc_argv *, int *, char *); static int argv_multi(struct mdoc *, int, struct mdoc_argv *, int *, char *); -static int pwarn(struct mdoc *, int, int, enum mwarn); -static int perr(struct mdoc *, int, int, enum merr); -#define verr(m, t) perr((m), (m)->last->line, (m)->last->pos, (t)) - /* Per-argument flags. */ static int mdoc_argvflags[MDOC_ARG_MAX] = { @@ -112,54 +87,54 @@ static int mdoc_argflags[MDOC_MAX] = { 0, /* Dd */ 0, /* Dt */ 0, /* Os */ - ARGS_QUOTED, /* Sh */ - ARGS_QUOTED, /* Ss */ + 0, /* Sh */ + 0, /* Ss */ ARGS_DELIM, /* Pp */ ARGS_DELIM, /* D1 */ - ARGS_DELIM | ARGS_QUOTED, /* Dl */ + ARGS_DELIM, /* Dl */ 0, /* Bd */ 0, /* Ed */ - ARGS_QUOTED, /* Bl */ + 0, /* Bl */ 0, /* El */ 0, /* It */ ARGS_DELIM, /* Ad */ ARGS_DELIM, /* An */ - ARGS_DELIM | ARGS_QUOTED, /* Ar */ - ARGS_QUOTED, /* Cd */ + ARGS_DELIM, /* Ar */ + 0, /* Cd */ ARGS_DELIM, /* Cm */ ARGS_DELIM, /* Dv */ ARGS_DELIM, /* Er */ ARGS_DELIM, /* Ev */ 0, /* Ex */ - ARGS_DELIM | ARGS_QUOTED, /* Fa */ + ARGS_DELIM, /* Fa */ 0, /* Fd */ ARGS_DELIM, /* Fl */ - ARGS_DELIM | ARGS_QUOTED, /* Fn */ - ARGS_DELIM | ARGS_QUOTED, /* Ft */ + ARGS_DELIM, /* Fn */ + ARGS_DELIM, /* Ft */ ARGS_DELIM, /* Ic */ 0, /* In */ - ARGS_DELIM | ARGS_QUOTED, /* Li */ - ARGS_QUOTED, /* Nd */ + ARGS_DELIM, /* Li */ + 0, /* Nd */ ARGS_DELIM, /* Nm */ ARGS_DELIM, /* Op */ 0, /* Ot */ ARGS_DELIM, /* Pa */ 0, /* Rv */ - ARGS_DELIM | ARGS_ARGVLIKE, /* St */ + ARGS_DELIM, /* St */ ARGS_DELIM, /* Va */ ARGS_DELIM, /* Vt */ ARGS_DELIM, /* Xr */ - ARGS_QUOTED, /* %A */ - ARGS_QUOTED, /* %B */ - ARGS_QUOTED, /* %D */ - ARGS_QUOTED, /* %I */ - ARGS_QUOTED, /* %J */ - ARGS_QUOTED, /* %N */ - ARGS_QUOTED, /* %O */ - ARGS_QUOTED, /* %P */ - ARGS_QUOTED, /* %R */ - ARGS_QUOTED, /* %T */ - ARGS_QUOTED, /* %V */ + 0, /* %A */ + 0, /* %B */ + 0, /* %D */ + 0, /* %I */ + 0, /* %J */ + 0, /* %N */ + 0, /* %O */ + 0, /* %P */ + 0, /* %R */ + 0, /* %T */ + 0, /* %V */ ARGS_DELIM, /* Ac */ 0, /* Ao */ ARGS_DELIM, /* Aq */ @@ -199,12 +174,12 @@ static int mdoc_argflags[MDOC_MAX] = { ARGS_DELIM, /* Sq */ 0, /* Sm */ ARGS_DELIM, /* Sx */ - ARGS_DELIM | ARGS_QUOTED, /* Sy */ + ARGS_DELIM, /* Sy */ ARGS_DELIM, /* Tn */ ARGS_DELIM, /* Ux */ ARGS_DELIM, /* Xc */ 0, /* Xo */ - ARGS_QUOTED, /* Fo */ + 0, /* Fo */ 0, /* Fc */ 0, /* Oo */ ARGS_DELIM, /* Oc */ @@ -216,16 +191,18 @@ static int mdoc_argflags[MDOC_MAX] = { 0, /* Ud */ 0, /* Lb */ ARGS_DELIM, /* Lp */ - ARGS_DELIM | ARGS_QUOTED, /* Lk */ - ARGS_DELIM | ARGS_QUOTED, /* Mt */ + ARGS_DELIM, /* Lk */ + ARGS_DELIM, /* Mt */ ARGS_DELIM, /* Brq */ 0, /* Bro */ ARGS_DELIM, /* Brc */ - ARGS_QUOTED, /* %C */ + 0, /* %C */ 0, /* Es */ 0, /* En */ 0, /* Dx */ - ARGS_QUOTED, /* %Q */ + 0, /* %Q */ + 0, /* br */ + 0, /* sp */ }; @@ -235,10 +212,9 @@ static int mdoc_argflags[MDOC_MAX] = { * one mandatory value, an optional single value, or no value. */ int -mdoc_argv(struct mdoc *mdoc, int line, int tok, +mdoc_argv(struct mdoc *m, int line, int tok, struct mdoc_arg **v, int *pos, char *buf) { - int i; char *p, sv; struct mdoc_argv tmp; struct mdoc_arg *arg; @@ -248,12 +224,8 @@ mdoc_argv(struct mdoc *mdoc, int line, int tok, assert(' ' != buf[*pos]); - if ('-' != buf[*pos] || ARGS_ARGVLIKE & mdoc_argflags[tok]) - return(ARGV_WORD); - /* Parse through to the first unescaped space. */ - i = *pos; p = &buf[++(*pos)]; assert(*pos > 0); @@ -284,21 +256,19 @@ mdoc_argv(struct mdoc *mdoc, int line, int tok, /* XXX - restore saved zeroed byte. */ if (sv) buf[*pos - 1] = sv; - if ( ! pwarn(mdoc, line, i, WARGVPARM)) - return(ARGV_ERROR); return(ARGV_WORD); } while (buf[*pos] && ' ' == buf[*pos]) (*pos)++; - if ( ! argv(mdoc, line, &tmp, pos, buf)) + if ( ! argv(m, line, &tmp, pos, buf)) return(ARGV_ERROR); if (NULL == (arg = *v)) { *v = calloc(1, sizeof(struct mdoc_arg)); if (NULL == *v) { - (void)verr(mdoc, EMALLOC); + (void)mdoc_nerr(m, m->last, EMALLOC); return(ARGV_ERROR); } arg = *v; @@ -309,7 +279,7 @@ mdoc_argv(struct mdoc *mdoc, int line, int tok, sizeof(struct mdoc_argv)); if (NULL == arg->argv) { - (void)verr(mdoc, EMALLOC); + (void)mdoc_nerr(m, m->last, EMALLOC); return(ARGV_ERROR); } @@ -351,60 +321,17 @@ mdoc_argv_free(struct mdoc_arg *p) } - -static int -perr(struct mdoc *mdoc, int line, int pos, enum merr code) +int +mdoc_zargs(struct mdoc *m, int line, int *pos, + char *buf, int flags, char **v) { - char *p; - p = NULL; - switch (code) { - case (EMALLOC): - p = "memory exhausted"; - break; - case (EQUOTTERM): - p = "unterminated quoted parameter"; - break; - case (EARGVAL): - p = "argument requires a value"; - break; - } - assert(p); - return(mdoc_perr(mdoc, line, pos, p)); + return(args(m, line, pos, buf, flags, v)); } -static int -pwarn(struct mdoc *mdoc, int line, int pos, enum mwarn code) -{ - char *p; - int c; - - p = NULL; - c = WARN_SYNTAX; - switch (code) { - case (WQUOTPARM): - p = "unexpected quoted parameter"; - break; - case (WARGVPARM): - p = "argument-like parameter"; - break; - case (WCOLEMPTY): - p = "last list column is empty"; - c = WARN_COMPAT; - break; - case (WTAILWS): - p = "trailing whitespace"; - c = WARN_COMPAT; - break; - } - assert(p); - return(mdoc_pwarn(mdoc, line, pos, c, p)); -} - - int -mdoc_args(struct mdoc *mdoc, int line, +mdoc_args(struct mdoc *m, int line, int *pos, char *buf, int tok, char **v) { int fl, c, i; @@ -412,73 +339,63 @@ mdoc_args(struct mdoc *mdoc, int line, fl = (0 == tok) ? 0 : mdoc_argflags[tok]; + if (MDOC_It != tok) + return(args(m, line, pos, buf, fl, v)); + /* - * Override per-macro argument flags with context-specific ones. - * As of now, this is only valid for `It' depending on its list - * context. + * The `It' macro is a special case, as it acquires parameters from its + * parent `Bl' context, specifically, we're concerned with -column. */ - switch (tok) { - case (MDOC_It): - for (n = mdoc->last; n; n = n->parent) - if (MDOC_BLOCK == n->type && MDOC_Bl == n->tok) - break; + for (n = m->last; n; n = n->parent) + if (MDOC_BLOCK == n->type && MDOC_Bl == n->tok) + break; - assert(n); - c = (int)(n->args ? n->args->argc : 0); - assert(c > 0); + assert(n); + c = (int)(n->args ? n->args->argc : 0); + assert(c > 0); - /* - * Using `Bl -column' adds ARGS_TABSEP to the arguments - * and invalidates ARGS_DELIM. Using `Bl -diag' allows - * for quoted arguments. - */ - - /* LINTED */ - for (i = 0; i < c; i++) { - switch (n->args->argv[i].arg) { - case (MDOC_Column): - fl |= ARGS_TABSEP; - fl &= ~ARGS_DELIM; - i = c; - break; - case (MDOC_Diag): - fl |= ARGS_QUOTED; - i = c; - break; - default: - break; - } - } + /* LINTED */ + for (i = 0; i < c; i++) { + if (MDOC_Column != n->args->argv[i].arg) + continue; + fl |= ARGS_TABSEP; + fl &= ~ARGS_DELIM; break; - default: - break; } - return(args(mdoc, line, pos, buf, fl, v)); + return(args(m, line, pos, buf, fl, v)); } static int -args(struct mdoc *mdoc, int line, - int *pos, char *buf, int fl, char **v) +args(struct mdoc *m, int line, int *pos, + char *buf, int fl, char **v) { int i; char *p, *pp; - assert(*pos > 0); + /* + * Parse out the terms (like `val' in `.Xx -arg val' or simply + * `.Xx val'), which can have all sorts of properties: + * + * ARGS_DELIM: use special handling if encountering trailing + * delimiters in the form of [[::delim::][ ]+]+. + * + * ARGS_NOWARN: don't post warnings. This is only used when + * re-parsing delimiters, as the warnings have already been + * posted. + * + * ARGS_TABSEP: use special handling for tab/`Ta' separated + * phrases like in `Bl -column'. + */ + assert(*pos); + assert(' ' != buf[*pos]); + if (0 == buf[*pos]) return(ARGS_EOLN); - if ('\"' == buf[*pos] && ! (fl & ARGS_QUOTED)) - if ( ! pwarn(mdoc, line, *pos, WQUOTPARM)) - return(ARGS_ERROR); - - if ( ! (fl & ARGS_ARGVLIKE) && '-' == buf[*pos]) - if ( ! pwarn(mdoc, line, *pos, WARGVPARM)) - return(ARGS_ERROR); - /* * If the first character is a delimiter and we're to look for * delimited strings, then pass down the buffer seeing if it @@ -490,167 +407,148 @@ args(struct mdoc *mdoc, int line, if ( ! mdoc_iscdelim(buf[i])) break; i++; - /* There must be at least one space... */ if (0 == buf[i] || ' ' != buf[i]) break; i++; while (buf[i] && ' ' == buf[i]) i++; } + if (0 == buf[i]) { *v = &buf[*pos]; + if (' ' != buf[i - 1]) + return(ARGS_PUNCT); + if (ARGS_NOWARN & fl) + return(ARGS_PUNCT); + if ( ! mdoc_pwarn(m, line, *pos, ETAILWS)) + return(ARGS_ERROR); return(ARGS_PUNCT); } } - /* First parse non-quoted strings. */ + *v = &buf[*pos]; - if ('\"' != buf[*pos] || ! (ARGS_QUOTED & fl)) { - *v = &buf[*pos]; + /* + * First handle TABSEP items, restricted to `Bl -column'. This + * ignores conventional token parsing and instead uses tabs or + * `Ta' macros to separate phrases. Phrases are parsed again + * for arguments at a later phase. + */ + if (ARGS_TABSEP & fl) { + /* Scan ahead to tab (can't be escaped). */ + p = strchr(*v, '\t'); + + /* Scan ahead to unescaped `Ta'. */ + for (pp = *v; ; pp++) { + if (NULL == (pp = strstr(pp, "Ta"))) + break; + if (pp > *v && ' ' != *(pp - 1)) + continue; + if (' ' == *(pp + 2) || 0 == *(pp + 2)) + break; + } + /* - * Thar be dragons here! If we're tab-separated, search - * ahead for either a tab or the `Ta' macro. - * If a `Ta' is detected, it must be space-buffered before and - * after. If either of these hold true, then prune out the - * extra spaces and call it an argument. + * Adjust new-buffer position to be beyond delimiter + * mark (e.g., Ta -> end + 2). */ + if (p && pp) { + *pos += pp < p ? 2 : 1; + p = pp < p ? pp : p; + } else if (p && ! pp) { + *pos += 1; + } else if (pp && ! p) { + p = pp; + *pos += 2; + } else + p = strchr(*v, 0); - if (ARGS_TABSEP & fl) { - /* Scan ahead to unescaped tab. */ + /* Whitespace check for eoln case... */ + if (0 == *p && ' ' == *(p - 1) && ! (ARGS_NOWARN & fl)) + if ( ! mdoc_pwarn(m, line, *pos, ETAILWS)) + return(ARGS_ERROR); - p = strchr(*v, '\t'); + *pos += (int)(p - *v); - /* Scan ahead to unescaped `Ta'. */ + /* Strip delimiter's preceding whitespace. */ + pp = p - 1; + while (pp > *v && ' ' == *pp) { + if (pp > *v && '\\' == *(pp - 1)) + break; + pp--; + } + *(pp + 1) = 0; - for (pp = *v; ; pp++) { - if (NULL == (pp = strstr(pp, "Ta"))) - break; - if (pp > *v && ' ' != *(pp - 1)) - continue; - if (' ' == *(pp + 2) || 0 == *(pp + 2)) - break; - } + /* Strip delimiter's proceeding whitespace. */ + for (pp = &buf[*pos]; ' ' == *pp; pp++, (*pos)++) + /* Skip ahead. */ ; - /* Choose delimiter tab/Ta. */ + return(ARGS_PHRASE); + } - if (p && pp) - p = (p < pp ? p : pp); - else if ( ! p && pp) - p = pp; + /* + * Process a quoted literal. A quote begins with a double-quote + * and ends with a double-quote NOT preceded by a double-quote. + * Whitespace is NOT involved in literal termination. + */ - /* Strip delimiter's preceding whitespace. */ + if ('\"' == buf[*pos]) { + *v = &buf[++(*pos)]; - if (p && p > *v) { - pp = p - 1; - while (pp > *v && ' ' == *pp) - pp--; - if (pp == *v && ' ' == *pp) - *pp = 0; - else if (' ' == *pp) - *(pp + 1) = 0; - } + for ( ; buf[*pos]; (*pos)++) { + if ('\"' != buf[*pos]) + continue; + if ('\"' != buf[*pos + 1]) + break; + (*pos)++; + } - /* ...in- and proceding whitespace. */ + if (0 == buf[*pos]) { + if (ARGS_NOWARN & fl) + return(ARGS_QWORD); + if ( ! mdoc_pwarn(m, line, *pos, EQUOTTERM)) + return(ARGS_ERROR); + return(ARGS_QWORD); + } - if (p && ('\t' != *p)) { - *p++ = 0; - *p++ = 0; - } else if (p) - *p++ = 0; - - if (p) { - while (' ' == *p) - p++; - if (0 != *p) - *(p - 1) = 0; - *pos += (int)(p - *v); - } - - if (p && 0 == *p) - if ( ! pwarn(mdoc, line, *pos, WCOLEMPTY)) - return(0); - if (p && 0 == *p && p > *v && ' ' == *(p - 1)) - if ( ! pwarn(mdoc, line, *pos, WTAILWS)) - return(0); - - if (p) - return(ARGS_PHRASE); - - /* Configure the eoln case, too. */ - - p = strchr(*v, 0); - assert(p); - - if (p > *v && ' ' == *(p - 1)) - if ( ! pwarn(mdoc, line, *pos, WTAILWS)) - return(0); - *pos += (int)(p - *v); - - return(ARGS_PHRASE); - } - - /* Do non-tabsep look-ahead here. */ - - if ( ! (ARGS_TABSEP & fl)) - while (buf[*pos]) { - if (' ' == buf[*pos]) - if ('\\' != buf[*pos - 1]) - break; - (*pos)++; - } - - if (0 == buf[*pos]) - return(ARGS_WORD); - buf[(*pos)++] = 0; if (0 == buf[*pos]) - return(ARGS_WORD); + return(ARGS_QWORD); - if ( ! (ARGS_TABSEP & fl)) - while (buf[*pos] && ' ' == buf[*pos]) - (*pos)++; + while (' ' == buf[*pos]) + (*pos)++; - if (buf[*pos]) - return(ARGS_WORD); + if (0 == buf[*pos] && ! (ARGS_NOWARN & fl)) + if ( ! mdoc_pwarn(m, line, *pos, ETAILWS)) + return(ARGS_ERROR); - if ( ! pwarn(mdoc, line, *pos, WTAILWS)) - return(ARGS_ERROR); - - return(ARGS_WORD); + return(ARGS_QWORD); } - /* - * If we're a quoted string (and quoted strings are allowed), - * then parse ahead to the next quote. If none's found, it's an - * error. After, parse to the next word. + /* + * A non-quoted term progresses until either the end of line or + * a non-escaped whitespace. */ - *v = &buf[++(*pos)]; + for ( ; buf[*pos]; (*pos)++) + if (' ' == buf[*pos] && '\\' != buf[*pos - 1]) + break; - while (buf[*pos] && '\"' != buf[*pos]) - (*pos)++; + if (0 == buf[*pos]) + return(ARGS_WORD); - if (0 == buf[*pos]) { - (void)perr(mdoc, line, *pos, EQUOTTERM); - return(ARGS_ERROR); - } - buf[(*pos)++] = 0; - if (0 == buf[*pos]) - return(ARGS_QWORD); - while (buf[*pos] && ' ' == buf[*pos]) + while (' ' == buf[*pos]) (*pos)++; - if (buf[*pos]) - return(ARGS_QWORD); + if (0 == buf[*pos] && ! (ARGS_NOWARN & fl)) + if ( ! mdoc_pwarn(m, line, *pos, ETAILWS)) + return(ARGS_ERROR); - if ( ! pwarn(mdoc, line, *pos, WTAILWS)) - return(ARGS_ERROR); - - return(ARGS_QWORD); + return(ARGS_WORD); } @@ -753,18 +651,16 @@ argv_a2arg(int tok, const char *argv) static int -argv_multi(struct mdoc *mdoc, int line, +argv_multi(struct mdoc *m, int line, struct mdoc_argv *v, int *pos, char *buf) { - int c, ppos; + int c; char *p; - ppos = *pos; - for (v->sz = 0; ; v->sz++) { if ('-' == buf[*pos]) break; - c = args(mdoc, line, pos, buf, ARGS_QUOTED, &p); + c = args(m, line, pos, buf, 0, &p); if (ARGS_ERROR == c) return(0); else if (ARGS_EOLN == c) @@ -774,12 +670,12 @@ argv_multi(struct mdoc *mdoc, int line, v->value = realloc(v->value, (v->sz + MULTI_STEP) * sizeof(char *)); if (NULL == v->value) { - (void)verr(mdoc, EMALLOC); + (void)mdoc_nerr(m, m->last, EMALLOC); return(ARGV_ERROR); } } if (NULL == (v->value[(int)v->sz] = strdup(p))) - return(verr(mdoc, EMALLOC)); + return(mdoc_nerr(m, m->last, EMALLOC)); } return(1); @@ -787,7 +683,7 @@ argv_multi(struct mdoc *mdoc, int line, static int -argv_opt_single(struct mdoc *mdoc, int line, +argv_opt_single(struct mdoc *m, int line, struct mdoc_argv *v, int *pos, char *buf) { int c; @@ -796,7 +692,7 @@ argv_opt_single(struct mdoc *mdoc, int line, if ('-' == buf[*pos]) return(1); - c = args(mdoc, line, pos, buf, ARGS_QUOTED, &p); + c = args(m, line, pos, buf, 0, &p); if (ARGS_ERROR == c) return(0); if (ARGS_EOLN == c) @@ -804,9 +700,9 @@ argv_opt_single(struct mdoc *mdoc, int line, v->sz = 1; if (NULL == (v->value = calloc(1, sizeof(char *)))) - return(verr(mdoc, EMALLOC)); + return(mdoc_nerr(m, m->last, EMALLOC)); if (NULL == (v->value[0] = strdup(p))) - return(verr(mdoc, EMALLOC)); + return(mdoc_nerr(m, m->last, EMALLOC)); return(1); } @@ -816,7 +712,7 @@ argv_opt_single(struct mdoc *mdoc, int line, * Parse a single, mandatory value from the stream. */ static int -argv_single(struct mdoc *mdoc, int line, +argv_single(struct mdoc *m, int line, struct mdoc_argv *v, int *pos, char *buf) { int c, ppos; @@ -824,17 +720,17 @@ argv_single(struct mdoc *mdoc, int line, ppos = *pos; - c = args(mdoc, line, pos, buf, ARGS_QUOTED, &p); + c = args(m, line, pos, buf, 0, &p); if (ARGS_ERROR == c) return(0); if (ARGS_EOLN == c) - return(perr(mdoc, line, ppos, EARGVAL)); + return(mdoc_perr(m, line, ppos, EARGVAL)); v->sz = 1; if (NULL == (v->value = calloc(1, sizeof(char *)))) - return(verr(mdoc, EMALLOC)); + return(mdoc_nerr(m, m->last, EMALLOC)); if (NULL == (v->value[0] = strdup(p))) - return(verr(mdoc, EMALLOC)); + return(mdoc_nerr(m, m->last, EMALLOC)); return(1); }