=================================================================== RCS file: /cvs/mandoc/roff.c,v retrieving revision 1.245 retrieving revision 1.246 diff -u -p -r1.245 -r1.246 --- mandoc/roff.c 2014/12/25 17:23:32 1.245 +++ mandoc/roff.c 2014/12/28 14:16:26 1.246 @@ -1,4 +1,4 @@ -/* $Id: roff.c,v 1.245 2014/12/25 17:23:32 schwarze Exp $ */ +/* $Id: roff.c,v 1.246 2014/12/28 14:16:26 schwarze Exp $ */ /* * Copyright (c) 2010, 2011, 2012 Kristaps Dzonsons * Copyright (c) 2010-2014 Ingo Schwarze @@ -651,6 +651,10 @@ roff_res(struct roff *r, struct buf *buf, int ln, int r->parse, ln, (int)(stesc - buf->buf), "%.*s", (int)naml, stnam); res = ""; + } else if (buf->sz + strlen(res) > SHRT_MAX) { + mandoc_msg(MANDOCERR_ROFFLOOP, r->parse, + ln, (int)(stesc - buf->buf), NULL); + return(ROFF_IGN); } /* Replace the escape sequence by the string. */ @@ -658,12 +662,6 @@ roff_res(struct roff *r, struct buf *buf, int ln, int *stesc = '\0'; buf->sz = mandoc_asprintf(&nbuf, "%s%s%s", buf->buf, res, cp) + 1; - - if (buf->sz > SHRT_MAX) { - mandoc_msg(MANDOCERR_ROFFLOOP, r->parse, - ln, (int)(stesc - buf->buf), NULL); - return(ROFF_IGN); - } /* Prepare for the next replacement. */