=================================================================== RCS file: /cvs/mandoc/term_ascii.c,v retrieving revision 1.45 retrieving revision 1.52 diff -u -p -r1.45 -r1.52 --- mandoc/term_ascii.c 2015/04/04 17:47:18 1.45 +++ mandoc/term_ascii.c 2015/11/12 21:50:03 1.52 @@ -1,4 +1,4 @@ -/* $Id: term_ascii.c,v 1.45 2015/04/04 17:47:18 schwarze Exp $ */ +/* $Id: term_ascii.c,v 1.52 2015/11/12 21:50:03 schwarze Exp $ */ /* * Copyright (c) 2010, 2011 Kristaps Dzonsons * Copyright (c) 2014, 2015 Ingo Schwarze @@ -38,8 +38,7 @@ #include "manconf.h" #include "main.h" -static struct termp *ascii_init(enum termenc, const struct mchars *, - const struct manoutput *); +static struct termp *ascii_init(enum termenc, const struct manoutput *); static int ascii_hspan(const struct termp *, const struct roffsu *); static size_t ascii_width(const struct termp *, int); @@ -59,15 +58,16 @@ static size_t locale_width(const struct termp *, in static struct termp * -ascii_init(enum termenc enc, const struct mchars *mchars, - const struct manoutput *outopts) +ascii_init(enum termenc enc, const struct manoutput *outopts) { +#if HAVE_WCHAR char *v; +#endif struct termp *p; p = mandoc_calloc(1, sizeof(struct termp)); - p->symtab = mchars; + p->line = 1; p->tabwidth = 5; p->defrmargin = p->lastrmargin = 78; p->fontq = mandoc_reallocarray(NULL, @@ -88,8 +88,16 @@ ascii_init(enum termenc enc, const struct mchars *mcha #if HAVE_WCHAR if (TERMENC_ASCII != enc) { + + /* + * Do not change any of this to LC_ALL. It might break + * the formatting by subtly changing the behaviour of + * various functions, for example strftime(3). As a + * worst case, it might even cause buffer overflows. + */ + v = TERMENC_LOCALE == enc ? - setlocale(LC_ALL, "") : + setlocale(LC_CTYPE, "") : setlocale(LC_CTYPE, "en_US.UTF-8"); if (NULL != v && MB_CUR_MAX > 1) { p->enc = enc; @@ -112,28 +120,28 @@ ascii_init(enum termenc enc, const struct mchars *mcha if (outopts->synopsisonly) p->synopsisonly = 1; - return(p); + return p; } void * -ascii_alloc(const struct mchars *mchars, const struct manoutput *outopts) +ascii_alloc(const struct manoutput *outopts) { - return(ascii_init(TERMENC_ASCII, mchars, outopts)); + return ascii_init(TERMENC_ASCII, outopts); } void * -utf8_alloc(const struct mchars *mchars, const struct manoutput *outopts) +utf8_alloc(const struct manoutput *outopts) { - return(ascii_init(TERMENC_UTF8, mchars, outopts)); + return ascii_init(TERMENC_UTF8, outopts); } void * -locale_alloc(const struct mchars *mchars, const struct manoutput *outopts) +locale_alloc(const struct manoutput *outopts) { - return(ascii_init(TERMENC_LOCALE, mchars, outopts)); + return ascii_init(TERMENC_LOCALE, outopts); } static void @@ -161,6 +169,7 @@ ascii_sepline(void *arg) size_t i; p = (struct termp *)arg; + p->line += 3; putchar('\n'); for (i = 0; i < p->defrmargin; i++) putchar('-'); @@ -172,7 +181,7 @@ static size_t ascii_width(const struct termp *p, int c) { - return(1); + return 1; } void @@ -207,6 +216,7 @@ static void ascii_endline(struct termp *p) { + p->line++; putchar('\n'); } @@ -241,7 +251,6 @@ ascii_hspan(const struct termp *p, const struct roffsu r = su->scale * 0.24; break; case SCALE_VS: - /* FALLTHROUGH */ case SCALE_PC: r = su->scale * 40.0; break; @@ -249,15 +258,13 @@ ascii_hspan(const struct termp *p, const struct roffsu r = su->scale * 10.0 / 3.0; break; case SCALE_EN: - /* FALLTHROUGH */ case SCALE_EM: r = su->scale * 24.0; break; default: abort(); - /* NOTREACHED */ } - return(r > 0.0 ? r + 0.01 : r - 0.01); + return r > 0.0 ? r + 0.01 : r - 0.01; } const char * @@ -332,8 +339,8 @@ ascii_uc2str(int uc) assert(uc >= 0); if ((size_t)uc < sizeof(tab)/sizeof(tab[0])) - return(tab[uc]); - return(mchars_uc2str(uc)); + return tab[uc]; + return mchars_uc2str(uc); } #if HAVE_WCHAR @@ -347,7 +354,7 @@ locale_width(const struct termp *p, int c) rc = wcwidth(c); if (rc < 0) rc = 0; - return(rc); + return rc; } static void @@ -363,6 +370,7 @@ static void locale_endline(struct termp *p) { + p->line++; putwchar(L'\n'); }