===================================================================
RCS file: /cvs/docbook2mdoc/docbook2mdoc.c,v
retrieving revision 1.80
retrieving revision 1.97
diff -u -p -r1.80 -r1.97
--- docbook2mdoc/docbook2mdoc.c	2019/04/02 16:24:23	1.80
+++ docbook2mdoc/docbook2mdoc.c	2019/04/07 17:42:36	1.97
@@ -1,4 +1,4 @@
-/* $Id: docbook2mdoc.c,v 1.80 2019/04/02 16:24:23 schwarze Exp $ */
+/* $Id: docbook2mdoc.c,v 1.97 2019/04/07 17:42:36 schwarze Exp $ */
 /*
  * Copyright (c) 2014 Kristaps Dzonsons <kristaps@bsd.lv>
  * Copyright (c) 2019 Ingo Schwarze <schwarze@openbsd.org>
@@ -32,14 +32,83 @@ static void	 pnode_print(struct format *, struct pnode
 
 
 static void
+pnode_printtext(struct format *f, struct pnode *n)
+{
+	struct pnode	*nn;
+	char		*cp;
+	char		 last;
+
+	if (n->bsz == 0) {
+		assert(n->real < n->b);
+		return;
+	}
+
+	/*
+	 * Text preceding a macro without intervening whitespace
+	 * requires a .Pf macro.
+	 * Set the spacing flag to avoid a redundant .Ns macro.
+	 */
+
+	if (f->linestate != LINE_MACRO &&
+	    (nn = TAILQ_NEXT(n, child)) != NULL && nn->spc == 0 &&
+	    (nn->node != NODE_TEXT && nn->node != NODE_ESCAPE)) {
+		macro_open(f, "Pf");
+		nn->spc = 1;
+	}
+
+	if (f->linestate == LINE_NEW) {
+		last = '\n';
+		f->linestate = LINE_TEXT;
+	} else {
+		last = ' ';
+		if (n->spc || f->linestate == LINE_MACRO)
+			putchar(' ');
+	}
+
+	if (n->node == NODE_ESCAPE) {
+		fputs(n->b, stdout);
+		return;
+	}
+
+	/*
+	 * Remove the prefix '-' from <option> elements
+	 * because the arguments of .Fl macros do not need it.
+	 */
+
+	cp = n->b;
+	if (n->parent != NULL && n->parent->node == NODE_OPTION && *cp == '-')
+		cp++;
+
+	/*
+	 * Print the text, skipping whitespace on new lines,
+	 * escaping control characters on new lines,
+	 * and escaping backslashes.
+	 */
+
+	for (; *cp != '\0'; cp++) {
+		if (last == '\n') {
+			if (isspace((unsigned char)*cp))
+				continue;
+			if (*cp == '\'' || *cp == '.')
+				fputs("\\&", stdout);
+		}
+		putchar(last = *cp);
+		if (last == '\\')
+			putchar('e');
+	}
+}
+
+static void
 pnode_printpara(struct format *p, struct pnode *pn)
 {
 	struct pnode	*pp;
 
-	if ((pp = TAILQ_PREV(pn, pnodeq, child)) == NULL &&
-	    (pp = pn->parent) == NULL)
+	if (pn->parent == NULL)
 		return;
 
+	if ((pp = TAILQ_PREV(pn, pnodeq, child)) == NULL)
+	    pp = pn->parent;
+
 	switch (pp->node) {
 	case NODE_ENTRY:
 	case NODE_LISTITEM:
@@ -129,9 +198,11 @@ pnode_printrefsect(struct format *p, struct pnode *pn)
 
 	switch (level) {
 	case 1:
+		macro_close(p);
 		macro_open(p, "Sh");
 		break;
 	case 2:
+		macro_close(p);
 		macro_open(p, "Ss");
 		break;
 	default:
@@ -172,7 +243,6 @@ pnode_printciterefentry(struct format *p, struct pnode
 		macro_addarg(p, "1", ARG_SPACE);
 	else
 		macro_addnode(p, manvol, ARG_SPACE | ARG_SINGLE);
-	macro_close(p);
 	pnode_unlinksub(pn);
 }
 
@@ -188,6 +258,7 @@ pnode_printrefmeta(struct format *p, struct pnode *pn)
 		else if (pp->node == NODE_REFENTRYTITLE)
 			title = pp;
 	}
+	macro_close(p);
 	macro_open(p, "Dt");
 	if (title == NULL)
 		macro_addarg(p, "UNKNOWN", ARG_SPACE);
@@ -202,25 +273,17 @@ pnode_printrefmeta(struct format *p, struct pnode *pn)
 }
 
 static void
-pnode_printfuncdef(struct format *p, struct pnode *pn)
+pnode_printfuncdef(struct format *f, struct pnode *n)
 {
-	struct pnode	*pp, *ftype, *func;
+	struct pnode	*nc;
 
-	ftype = func = NULL;
-	TAILQ_FOREACH(pp, &pn->childq, child) {
-		if (pp->node == NODE_TEXT)
-			ftype = pp;
-		else if (pp->node == NODE_FUNCTION)
-			func = pp;
+	nc = TAILQ_FIRST(&n->childq);
+	if (nc != NULL && nc->node == NODE_TEXT) {
+		macro_argline(f, "Ft", nc->b);
+		pnode_unlink(nc);
 	}
-	if (ftype != NULL)
-		macro_argline(p, "Ft", ftype->b);
-	macro_open(p, "Fo");
-	if (func == NULL)
-		macro_addarg(p, "UNKNOWN", ARG_SPACE);
-	else
-		macro_addnode(p, func, ARG_SPACE | ARG_SINGLE);
-	macro_close(p);
+	macro_nodeline(f, "Fo", n, ARG_SINGLE);
+	pnode_unlinksub(n);
 }
 
 /*
@@ -289,14 +352,14 @@ pnode_printfuncprototype(struct format *p, struct pnod
 		if (fdef->node == NODE_FUNCDEF)
 			break;
 
-	if (fdef != NULL)
+	if (fdef != NULL) {
 		pnode_printfuncdef(p, fdef);
-	else
+		pnode_unlink(fdef);
+	} else
 		macro_line(p, "Fo UNKNOWN");
 
 	TAILQ_FOREACH(pp, &pn->childq, child)
-		if (pp->node == NODE_PARAMDEF)
-			macro_nodeline(p, "Fa", pp, ARG_SINGLE);
+		macro_nodeline(p, "Fa", pp, ARG_SINGLE);
 
 	macro_line(p, "Fc");
 	pnode_unlinksub(pn);
@@ -460,6 +523,41 @@ pnode_printauthor(struct format *f, struct pnode *n)
 }
 
 static void
+pnode_printlink(struct format *f, struct pnode *n)
+{
+	const char	*uri, *text;
+
+	uri = pnode_getattr_raw(n, ATTRKEY_LINKEND, NULL);
+	if (uri != NULL) {
+		if (TAILQ_FIRST(&n->childq) != NULL) {
+			print_textnode(f, n);
+			text = "";
+		} else {
+			text = pnode_getattr_raw(n, ATTRKEY_ENDTERM, NULL);
+			if (text != NULL)
+				print_text(f, text, ARG_SPACE);
+		}
+		if (text != NULL)
+			macro_open(f, "Pq");
+		macro_open(f, "Sx");
+		macro_addarg(f, uri, ARG_SPACE);
+		pnode_unlinksub(n);
+		return;
+	}
+	uri = pnode_getattr_raw(n, ATTRKEY_XLINK_HREF, NULL);
+	if (uri == NULL)
+		uri = pnode_getattr_raw(n, ATTRKEY_URL, NULL);
+	if (uri != NULL) {
+		macro_open(f, "Lk");
+		macro_addarg(f, uri, ARG_SPACE | ARG_SINGLE);
+		if (TAILQ_FIRST(&n->childq) != NULL)
+			macro_addnode(f, n, ARG_SPACE | ARG_SINGLE);
+		pnode_unlinksub(n);
+		return;
+	}
+}
+
+static void
 pnode_printprologue(struct format *p, struct ptree *tree)
 {
 	struct pnode	*refmeta;
@@ -496,6 +594,7 @@ pnode_printvarlistentry(struct format *p, struct pnode
 	struct pnode	*pp;
 	int		 first = 1;
 
+	macro_close(p);
 	macro_open(p, "It");
 	TAILQ_FOREACH(pp, &pn->childq, child) {
 		if (pp->node != NODE_TERM)
@@ -541,21 +640,67 @@ pnode_printrow(struct format *p, struct pnode *pn)
 }
 
 static void
-pnode_printtable(struct format *p, struct pnode *pn)
+pnode_printtgroup1(struct format *f, struct pnode *n)
 {
-	struct pnode	*pp;
+	struct pnode	*nc;
 
-	pnode_printtitle(p, pn);
-	macro_line(p, "Bl -ohang");
-	while ((pp = pnode_findfirst(pn, NODE_ROW)) != NULL) {
-		macro_line(p, "It Table Row");
-		pnode_printrow(p, pp);
+	macro_line(f, "Bl -bullet -compact");
+	while ((nc = pnode_findfirst(n, NODE_ENTRY)) != NULL) {
+		macro_line(f, "It");
+		pnode_print(f, nc);
+		pnode_unlink(nc);
 	}
-	macro_line(p, "El");
-	pnode_unlinksub(pn);
+	macro_line(f, "El");
+	pnode_unlinksub(n);
 }
 
 static void
+pnode_printtgroup2(struct format *f, struct pnode *n)
+{
+	struct pnode	*nr, *ne;
+
+	macro_line(f, "Bl -tag -width Ds");
+	while ((nr = pnode_findfirst(n, NODE_ROW)) != NULL) {
+		if ((ne = pnode_findfirst(n, NODE_ENTRY)) == NULL)
+			break;
+		macro_close(f);
+		macro_open(f, "It");
+		pnode_print(f, ne);
+		macro_close(f);
+		pnode_unlink(ne);
+		pnode_print(f, nr);
+		pnode_unlink(nr);
+	}
+	macro_line(f, "El");
+	pnode_unlinksub(n);
+}
+
+static void
+pnode_printtgroup(struct format *f, struct pnode *n)
+{
+	struct pnode	*nc;
+
+	switch (atoi(pnode_getattr_raw(n, ATTRKEY_COLS, "0"))) {
+	case 1:
+		pnode_printtgroup1(f, n);
+		return;
+	case 2:
+		pnode_printtgroup2(f, n);
+		return;
+	default:
+		break;
+	}
+
+	macro_line(f, "Bl -ohang");
+	while ((nc = pnode_findfirst(n, NODE_ROW)) != NULL) {
+		macro_line(f, "It Table Row");
+		pnode_printrow(f, nc);
+	}
+	macro_line(f, "El");
+	pnode_unlinksub(n);
+}
+
+static void
 pnode_printlist(struct format *p, struct pnode *pn)
 {
 	struct pnode	*pp;
@@ -580,7 +725,7 @@ pnode_printvariablelist(struct format *p, struct pnode
 	macro_line(p, "Bl -tag -width Ds");
 	TAILQ_FOREACH(pp, &pn->childq, child) {
 		if (pp->node == NODE_VARLISTENTRY)
-			pnode_print(p, pp);
+			pnode_printvarlistentry(p, pp);
 		else
 			macro_nodeline(p, "It", pp, 0);
 	}
@@ -598,14 +743,12 @@ static void
 pnode_print(struct format *p, struct pnode *pn)
 {
 	struct pnode	*pp;
-	const char	*ccp;
-	char		*cp;
-	int		 last;
 	enum linestate	 sv;
 
 	if (pn == NULL)
 		return;
 
+	p->spc = pn->spc;
 	sv = p->linestate;
 
 	switch (pn->node) {
@@ -630,9 +773,6 @@ pnode_print(struct format *p, struct pnode *pn)
 	case NODE_CITETITLE:
 		macro_open(p, "%T");
 		break;
-	case NODE_CODE:
-		macro_open(p, "Li");
-		break;
 	case NODE_COMMAND:
 		macro_open(p, "Nm");
 		break;
@@ -641,6 +781,7 @@ pnode_print(struct format *p, struct pnode *pn)
 		break;
 	case NODE_EDITOR:
 		print_text(p, "editor:", ARG_SPACE);
+		sv = LINE_TEXT;
 		macro_open(p, "An");
 		break;
 	case NODE_EMAIL:
@@ -653,12 +794,8 @@ pnode_print(struct format *p, struct pnode *pn)
 	case NODE_ENVAR:
 		macro_open(p, "Ev");
 		break;
-	case NODE_ESCAPE:
-		if (p->linestate == LINE_NEW)
-			p->linestate = LINE_TEXT;
-		else
-			putchar(' ');
-		fputs(pn->b, stdout);
+	case NODE_ERRORNAME:
+		macro_open(p, "Er");
 		break;
 	case NODE_FILENAME:
 		macro_open(p, "Pa");
@@ -693,15 +830,13 @@ pnode_print(struct format *p, struct pnode *pn)
 		macro_line(p, "Sh LEGAL NOTICE");
 		break;
 	case NODE_LINK:
-		ccp = pnode_getattr_raw(pn, ATTRKEY_LINKEND, NULL);
-		if (ccp == NULL)
-			break;
-		macro_argline(p, "Sx", ccp);
-		return;
+		pnode_printlink(p, pn);
+		break;
 	case NODE_LITERAL:
-		macro_open(p, "Li");
+		macro_open(p, "Ql");
 		break;
 	case NODE_LITERALLAYOUT:
+		macro_close(p);
 		macro_argline(p, "Bd", pnode_getattr(pn, ATTRKEY_CLASS) ==
 		    ATTRVAL_MONOSPACED ? "-literal" : "-unfilled");
 		break;
@@ -730,6 +865,7 @@ pnode_print(struct format *p, struct pnode *pn)
 	case NODE_PARA:
 		pnode_printpara(p, pn);
 		break;
+	case NODE_PARAMDEF:
 	case NODE_PARAMETER:
 		macro_nodeline(p, "Fa", pn, ARG_SINGLE);
 		pnode_unlinksub(pn);
@@ -739,15 +875,13 @@ pnode_print(struct format *p, struct pnode *pn)
 		break;
 	case NODE_PROGRAMLISTING:
 	case NODE_SCREEN:
+	case NODE_SYNOPSIS:
 		macro_line(p, "Bd -literal");
 		break;
 	case NODE_REFENTRYINFO:
 		/* Suppress. */
 		pnode_unlinksub(pn);
 		break;
-	case NODE_REFMETA:
-		abort();
-		break;
 	case NODE_REFNAME:
 		/* Suppress non-text children... */
 		macro_open(p, "Nm");
@@ -778,74 +912,31 @@ pnode_print(struct format *p, struct pnode *pn)
 		macro_line(p, "br");
 		break;
 	case NODE_SGMLTAG:
-		macro_open(p, "Li");
+		macro_open(p, "Ic");
 		break;
-	case NODE_STRUCTNAME:
-		macro_open(p, "Vt");
+	case NODE_TEXT:
+	case NODE_ESCAPE:
+		pnode_printtext(p, pn);
 		break;
-	case NODE_TABLE:
-	case NODE_INFORMALTABLE:
-		pnode_printtable(p, pn);
+	case NODE_TGROUP:
+		pnode_printtgroup(p, pn);
 		break;
-	case NODE_TEXT:
-		if (pn->bsz == 0) {
-			assert(pn->real != pn->b);
+	case NODE_TITLE:
+		if (pn->parent != NULL &&
+		    pn->parent->node == NODE_BOOKINFO) {
+			macro_open(p, "Nd");
 			break;
 		}
-		if (p->linestate == LINE_NEW)
-			p->linestate = LINE_TEXT;
-		else
-			putchar(' ');
-
-		/*
-		 * Output all characters, squeezing out whitespace
-		 * between newlines.
-		 * XXX: all whitespace, including tabs (?).
-		 * Remember to escape control characters and escapes.
-		 */
-		cp = pn->b;
-
-		/*
-		 * There's often a superfluous "-" in its <option> tags
-		 * before the actual flags themselves.
-		 * "Fl" does this for us, so remove it.
-		 */
-		if (pn->parent != NULL &&
-		    pn->parent->node == NODE_OPTION &&
-		    *cp == '-')
-			cp++;
-		for (last = '\n'; *cp != '\0'; ) {
-			if (last == '\n') {
-				/* Consume all whitespace. */
-				if (isspace((unsigned char)*cp)) {
-					while (isspace((unsigned char)*cp))
-						cp++;
-					continue;
-				} else if (*cp == '\'' || *cp == '.')
-					fputs("\\&", stdout);
-			}
-			putchar(last = *cp++);
-			/* If we're a character escape, escape us. */
-			if (last == '\\')
-				putchar('e');
-		}
+		pnode_printpara(p, pn);
+		macro_nodeline(p, "Sy", pn, 0);
+		pnode_unlinksub(pn);
 		break;
-	case NODE_TITLE:
-		if (pn->parent->node == NODE_BOOKINFO)
-			macro_open(p, "Nd");
-		break;
 	case NODE_TYPE:
 		macro_open(p, "Vt");
 		break;
-	case NODE_USERINPUT:
-		macro_open(p, "Li");
-		break;
 	case NODE_VARIABLELIST:
 		pnode_printvariablelist(p, pn);
 		break;
-	case NODE_VARLISTENTRY:
-		pnode_printvarlistentry(p, pn);
-		break;
 	case NODE_VARNAME:
 		macro_open(p, "Va");
 		break;
@@ -864,6 +955,24 @@ pnode_print(struct format *p, struct pnode *pn)
 		fputs("$ ", stdout);
 		p->linestate = sv;
 		break;
+	case NODE_MEMBER:
+		if ((pp = TAILQ_NEXT(pn, child)) != NULL &&
+		    pp->node != NODE_MEMBER)
+			pp = NULL;
+		switch (p->linestate) {
+		case LINE_TEXT:
+			if (pp != NULL)
+				print_text(p, ",", 0);
+			break;
+		case LINE_MACRO:
+			if (pp != NULL)
+				macro_addarg(p, ",", ARG_SPACE);
+			macro_close(p);
+			break;
+		case LINE_NEW:
+			break;
+		}
+		break;
 	case NODE_MML_MROW:
 	case NODE_MML_MI:
 	case NODE_MML_MN:
@@ -877,29 +986,29 @@ pnode_print(struct format *p, struct pnode *pn)
 	case NODE_AUTHOR:
 	case NODE_CITEREFENTRY:
 	case NODE_CITETITLE:
-	case NODE_CODE:
 	case NODE_COMMAND:
 	case NODE_CONSTANT:
 	case NODE_EDITOR:
 	case NODE_EMAIL:
 	case NODE_EMPHASIS:
 	case NODE_ENVAR:
+	case NODE_ERRORNAME:
 	case NODE_FILENAME:
 	case NODE_FIRSTTERM:
 	case NODE_FUNCTION:
 	case NODE_FUNCSYNOPSISINFO:
 	case NODE_KEYSYM:
+	case NODE_LINK:
 	case NODE_LITERAL:
 	case NODE_OPTION:
 	case NODE_PARAMETER:
 	case NODE_REPLACEABLE:
 	case NODE_REFPURPOSE:
 	case NODE_SGMLTAG:
-	case NODE_STRUCTNAME:
 	case NODE_TYPE:
-	case NODE_USERINPUT:
 	case NODE_VARNAME:
-		if (sv != LINE_MACRO && p->linestate == LINE_MACRO)
+		if (sv != LINE_MACRO && p->linestate == LINE_MACRO &&
+		    (pn->parent == NULL || pn->parent->node != NODE_MEMBER))
 			macro_closepunct(p, pn);
 		break;
 	case NODE_QUOTE:
@@ -935,10 +1044,12 @@ pnode_print(struct format *p, struct pnode *pn)
 	case NODE_LITERALLAYOUT:
 	case NODE_PROGRAMLISTING:
 	case NODE_SCREEN:
+	case NODE_SYNOPSIS:
 		macro_line(p, "Ed");
 		break;
 	case NODE_TITLE:
-		if (pn->parent->node == NODE_BOOKINFO)
+		if (pn->parent != NULL &&
+		    pn->parent->node == NODE_BOOKINFO)
 			macro_line(p, "Sh AUTHORS");
 		break;
 	default: