Up to [cvsweb.bsd.lv] / mandoc
Request diff between arbitrary revisions
Default branch: MAIN
Current tag: VERSION_1_14_4
Revision 1.5 / (download) - annotate - [select for diffs], Sun Aug 17 20:53:50 2014 UTC (8 years, 7 months ago) by schwarze
Branch: MAIN
CVS Tags: VERSION_1_14_5,
VERSION_1_14_4,
VERSION_1_14_3,
VERSION_1_14_2,
VERSION_1_14_1,
VERSION_1_13_4,
VERSION_1_13_3,
VERSION_1_13_2,
VERSION_1_13
Changes since 1.4: +2 -8 lines
Diff to previous 1.4 (unified)
Do not require getsubopt() to provide extern char *suboptarg. We don't use it anyway in mandoc. Like this, fewer systems need the compat implementation. In particular, we can now use the stock getsubopt() on glibc and musl. Besides, the comment in the BSD getsubopt.c that error messages are tricky without *suboptarg is massively overblown. If you simply save a copy of the pointer you pass into getsubopt(), that's quite usable for an error message. People start campaigning for the addition of *suboptarg to C libraries on the grounds that mandoc wants it, but actually, i consider library functions manipulating global data quite ugly, so stop pushing people into that questionable direction. While here, add an explicit Copyright header to the test file. While it's obviously to me what Kristaps intended, others might consider this file copyrightable and wonder what's up.