=================================================================== RCS file: /cvs/mandoc/main.c,v retrieving revision 1.112 retrieving revision 1.115 diff -u -p -r1.112 -r1.115 --- mandoc/main.c 2010/12/01 16:28:23 1.112 +++ mandoc/main.c 2010/12/02 20:41:46 1.115 @@ -1,4 +1,4 @@ -/* $Id: main.c,v 1.112 2010/12/01 16:28:23 kristaps Exp $ */ +/* $Id: main.c,v 1.115 2010/12/02 20:41:46 schwarze Exp $ */ /* * Copyright (c) 2008, 2009, 2010 Kristaps Dzonsons * Copyright (c) 2010 Ingo Schwarze @@ -122,6 +122,7 @@ static const char * const mandocerrs[MANDOCERR_MAX] = "generic warning", + ".so is fragile, better use ln(1)", "text should be uppercase", "sections out of conventional order", "section name repeats", @@ -190,6 +191,7 @@ static const char * const mandocerrs[MANDOCERR_MAX] = "argument count wrong, violates syntax", "child violates parent syntax", "argument count wrong, violates syntax", + "NOT IMPLEMENTED: .so with absolute path or \"..\"", "no document body", "no document prologue", "utsname system call failed", @@ -211,6 +213,7 @@ static void version(void) __attribute__((noreturn)) static int woptions(struct curparse *, char *); static const char *progname; +static enum mandoclevel file_status = MANDOCLEVEL_OK; static enum mandoclevel exit_status = MANDOCLEVEL_OK; int @@ -347,7 +350,7 @@ pfile(const char *file, struct curparse *curp) if (-1 == (fd = open(file, O_RDONLY, 0))) { perror(file); - exit_status = MANDOCLEVEL_SYSERR; + file_status = MANDOCLEVEL_SYSERR; return(0); } @@ -365,7 +368,7 @@ pfile(const char *file, struct curparse *curp) if (-1 == close(fd)) perror(file); - return(MANDOCLEVEL_FATAL > exit_status ? 1 : 0); + return(MANDOCLEVEL_FATAL > file_status ? 1 : 0); } @@ -469,6 +472,7 @@ fdesc(struct curparse *curp) curp->mdoc = NULL; curp->man = NULL; + file_status = MANDOCLEVEL_OK; /* Make sure the mandotory roff parser is initialised. */ @@ -481,32 +485,32 @@ fdesc(struct curparse *curp) pdesc(curp); - if (MANDOCLEVEL_FATAL <= exit_status) + if (MANDOCLEVEL_FATAL <= file_status) goto cleanup; /* NOTE a parser may not have been assigned, yet. */ if ( ! (curp->man || curp->mdoc)) { fprintf(stderr, "%s: Not a manual\n", curp->file); - exit_status = MANDOCLEVEL_FATAL; + file_status = MANDOCLEVEL_FATAL; goto cleanup; } /* Clean up the parse routine ASTs. */ if (curp->mdoc && ! mdoc_endparse(curp->mdoc)) { - assert(MANDOCLEVEL_FATAL <= exit_status); + assert(MANDOCLEVEL_FATAL <= file_status); goto cleanup; } if (curp->man && ! man_endparse(curp->man)) { - assert(MANDOCLEVEL_FATAL <= exit_status); + assert(MANDOCLEVEL_FATAL <= file_status); goto cleanup; } assert(curp->roff); if ( ! roff_endparse(curp->roff)) { - assert(MANDOCLEVEL_FATAL <= exit_status); + assert(MANDOCLEVEL_FATAL <= file_status); goto cleanup; } @@ -515,7 +519,7 @@ fdesc(struct curparse *curp) * the requested level, do not produce output. */ - if (MANDOCLEVEL_OK != exit_status && curp->wstop) + if (MANDOCLEVEL_OK != file_status && curp->wstop) goto cleanup; /* If unset, allocate output dev now (if applicable). */ @@ -590,6 +594,9 @@ fdesc(struct curparse *curp) assert(curp->roff); roff_reset(curp->roff); + if (exit_status < file_status) + exit_status = file_status; + return; } @@ -607,7 +614,7 @@ pdesc(struct curparse *curp) */ if ( ! read_whole_file(curp, &blk, &with_mmap)) { - exit_status = MANDOCLEVEL_SYSERR; + file_status = MANDOCLEVEL_SYSERR; return; } @@ -627,6 +634,7 @@ static void parsebuf(struct curparse *curp, struct buf blk, int start) { struct buf ln; + enum rofferr rr; int i, of, rc; int pos; /* byte number in the ln buffer */ int lnn; /* line number in the real file */ @@ -741,11 +749,11 @@ parsebuf(struct curparse *curp, struct buf blk, int st of = 0; rerun: - rc = roff_parseln + rr = roff_parseln (curp->roff, curp->line, &ln.buf, &ln.sz, of, &of); - switch (rc) { + switch (rr) { case (ROFF_REPARSE): parsebuf(curp, ln, 0); pos = 0; @@ -759,7 +767,7 @@ rerun: pos = 0; continue; case (ROFF_ERR): - assert(MANDOCLEVEL_FATAL <= exit_status); + assert(MANDOCLEVEL_FATAL <= file_status); break; case (ROFF_SO): if (pfile(ln.buf + of, curp)) { @@ -795,7 +803,7 @@ rerun: curp->line, ln.buf, of); if ( ! rc) { - assert(MANDOCLEVEL_FATAL <= exit_status); + assert(MANDOCLEVEL_FATAL <= file_status); break; } } @@ -977,8 +985,8 @@ mmsg(enum mandocerr t, void *arg, int ln, int col, con fprintf(stderr, ": %s", msg); fputc('\n', stderr); - if (exit_status < level) - exit_status = level; + if (file_status < level) + file_status = level; return(level < MANDOCLEVEL_FATAL); }