=================================================================== RCS file: /cvs/mandoc/man_validate.c,v retrieving revision 1.51 retrieving revision 1.54 diff -u -p -r1.51 -r1.54 --- mandoc/man_validate.c 2010/11/30 15:24:27 1.51 +++ mandoc/man_validate.c 2010/12/06 13:56:56 1.54 @@ -1,4 +1,4 @@ -/* $Id: man_validate.c,v 1.51 2010/11/30 15:24:27 kristaps Exp $ */ +/* $Id: man_validate.c,v 1.54 2010/12/06 13:56:56 kristaps Exp $ */ /* * Copyright (c) 2008, 2009, 2010 Kristaps Dzonsons * @@ -70,7 +70,6 @@ static v_check posts_part[] = { check_part, NULL }; static v_check posts_sec[] = { check_sec, NULL }; static v_check posts_th[] = { check_ge2, check_le5, check_title, post_TH, NULL }; static v_check posts_uc[] = { post_UC, NULL }; -static v_check posts_vb[] = { check_le1, post_nf, NULL }; static v_check pres_bline[] = { check_bline, NULL }; @@ -107,9 +106,6 @@ static const struct man_valid man_valids[MAN_MAX] = { { NULL, NULL }, /* DT */ { NULL, posts_uc }, /* UC */ { NULL, NULL }, /* PD */ - { NULL, posts_le1 }, /* Sp */ /* FIXME: should warn only. */ - { pres_bline, posts_vb }, /* Vb */ /* FIXME: should warn only. */ - { pres_bline, posts_fi }, /* Ve */ { NULL, posts_at }, /* AT */ { NULL, NULL }, /* in */ }; @@ -167,9 +163,9 @@ check_root(CHKARGS) { if (MAN_BLINE & m->flags) - return(man_nmsg(m, n, MANDOCERR_SCOPEEXIT)); - if (MAN_ELINE & m->flags) - return(man_nmsg(m, n, MANDOCERR_SCOPEEXIT)); + man_nmsg(m, n, MANDOCERR_SCOPEEXIT); + else if (MAN_ELINE & m->flags) + man_nmsg(m, n, MANDOCERR_SCOPEEXIT); m->flags &= ~MAN_BLINE; m->flags &= ~MAN_ELINE; @@ -178,14 +174,13 @@ check_root(CHKARGS) man_nmsg(m, n, MANDOCERR_NODOCBODY); return(0); } else if (NULL == m->meta.title) { - if ( ! man_nmsg(m, n, MANDOCERR_NOTITLE)) - return(0); + man_nmsg(m, n, MANDOCERR_NOTITLE); + /* * If a title hasn't been set, do so now (by * implication, date and section also aren't set). - * - * FIXME: this should be in man_action.c. */ + m->meta.title = mandoc_strdup("unknown"); m->meta.date = time(NULL); m->meta.msec = mandoc_strdup("1"); @@ -208,9 +203,11 @@ check_title(CHKARGS) } for (p = n->child->string; '\0' != *p; p++) - if (isalpha((u_char)*p) && ! isupper((u_char)*p)) - if ( ! man_nmsg(m, n, MANDOCERR_UPPERCASE)) - return(0); + /* Only warn about this once... */ + if (isalpha((u_char)*p) && ! isupper((u_char)*p)) { + man_nmsg(m, n, MANDOCERR_UPPERCASE); + break; + } return(1); } @@ -280,7 +277,7 @@ check_sec(CHKARGS) man_nmsg(m, n, MANDOCERR_SYNTARGCOUNT); return(0); } else if (MAN_BODY == n->type && 0 == n->nchild) - return(man_nmsg(m, n, MANDOCERR_NOBODY)); + man_nmsg(m, n, MANDOCERR_NOBODY); return(1); } @@ -291,7 +288,8 @@ check_part(CHKARGS) { if (MAN_BODY == n->type && 0 == n->nchild) - return(man_nmsg(m, n, MANDOCERR_NOBODY)); + man_nmsg(m, n, MANDOCERR_NOBODY); + return(1); } @@ -310,9 +308,9 @@ check_par(CHKARGS) /* Body-less lists are ok. */ break; default: - if (n->nchild) - break; - return(man_nmsg(m, n, MANDOCERR_NOBODY)); + if (0 == n->nchild) + man_nmsg(m, n, MANDOCERR_NOBODY); + break; } if (MAN_HEAD == n->type) switch (n->tok) { @@ -321,13 +319,11 @@ check_par(CHKARGS) case (MAN_P): /* FALLTHROUGH */ case (MAN_LP): - if (0 == n->nchild) - break; - return(man_nmsg(m, n, MANDOCERR_ARGSLOST)); - default: if (n->nchild) - break; - return(man_nmsg(m, n, MANDOCERR_NOARGS)); + man_nmsg(m, n, MANDOCERR_ARGSLOST); + break; + default: + break; } return(1);