=================================================================== RCS file: /cvs/mandoc/out.c,v retrieving revision 1.82 retrieving revision 1.84 diff -u -p -r1.82 -r1.84 --- mandoc/out.c 2021/09/07 17:07:58 1.82 +++ mandoc/out.c 2021/10/17 20:48:28 1.84 @@ -1,4 +1,4 @@ -/* $Id: out.c,v 1.82 2021/09/07 17:07:58 schwarze Exp $ */ +/* $Id: out.c,v 1.84 2021/10/17 20:48:28 schwarze Exp $ */ /* * Copyright (c) 2009, 2010, 2011 Kristaps Dzonsons * Copyright (c) 2011, 2014, 2015, 2017, 2018, 2019, 2021 @@ -123,6 +123,7 @@ tblcalc(struct rofftbl *tbl, const struct tbl_span *sp const struct tbl_dat *dp; struct roffcol *col; struct tbl_colgroup *first_group, **gp, *g; + size_t *colwidth; size_t ewidth, min1, min2, wanted, width, xwidth; int done, icol, maxcol, necol, nxcol, quirkcol; @@ -148,7 +149,6 @@ tblcalc(struct rofftbl *tbl, const struct tbl_span *sp * to data cells in the data section. */ - gp = &first_group; for (dp = sp->first; dp != NULL; dp = dp->next) { icol = dp->layout->col; while (maxcol < icol + dp->hspans) @@ -189,16 +189,16 @@ tblcalc(struct rofftbl *tbl, const struct tbl_span *sp continue; /* - * Build an ordered, singly linked list + * Build a singly linked list * of all groups of columns joined by spans, * recording the minimum width for each group. */ - while (*gp != NULL && ((*gp)->startcol < icol || - (*gp)->endcol < icol + dp->hspans)) + gp = &first_group; + while (*gp != NULL && ((*gp)->startcol != icol || + (*gp)->endcol != icol + dp->hspans)) gp = &(*gp)->next; - if (*gp == NULL || (*gp)->startcol > icol || - (*gp)->endcol > icol + dp->hspans) { + if (*gp == NULL) { g = mandoc_malloc(sizeof(*g)); g->next = *gp; g->wanted = width; @@ -256,16 +256,28 @@ tblcalc(struct rofftbl *tbl, const struct tbl_span *sp gp = &(*gp)->next; } + colwidth = mandoc_reallocarray(NULL, maxcol + 1, sizeof(*colwidth)); while (first_group != NULL) { /* + * Rebuild the array of the widths of all columns + * participating in spans that require expansion. + */ + + for (icol = 0; icol <= maxcol; icol++) + colwidth[icol] = SIZE_MAX; + for (g = first_group; g != NULL; g = g->next) + for (icol = g->startcol; icol <= g->endcol; icol++) + colwidth[icol] = tbl->cols[icol].width; + + /* * Find the smallest and second smallest column width * among the columns which may need expamsion. */ min1 = min2 = SIZE_MAX; for (icol = 0; icol <= maxcol; icol++) { - width = tbl->cols[icol].width; + width = colwidth[icol]; if (min1 > width) { min2 = min1; min1 = width; @@ -283,7 +295,7 @@ tblcalc(struct rofftbl *tbl, const struct tbl_span *sp for (g = first_group; g != NULL; g = g->next) { necol = 0; for (icol = g->startcol; icol <= g->endcol; icol++) - if (tbl->cols[icol].width == min1) + if (colwidth[icol] == min1) necol++; if (necol == 0) continue; @@ -300,7 +312,7 @@ tblcalc(struct rofftbl *tbl, const struct tbl_span *sp while ((g = *gp) != NULL) { done = 0; for (icol = g->startcol; icol <= g->endcol; icol++) { - if (tbl->cols[icol].width != min1) + if (colwidth[icol] != min1) continue; if (g->wanted <= wanted - min1) { tbl->cols[icol].width += g->wanted; @@ -317,6 +329,7 @@ tblcalc(struct rofftbl *tbl, const struct tbl_span *sp gp = &(*gp)->next; } } + free(colwidth); /* * Align numbers with text. @@ -540,5 +553,7 @@ tblcalc_number(struct rofftbl *tbl, struct roffcol *co col->nwidth = totsz; if (col->nwidth > col->width) col->width = col->nwidth; + fprintf(stderr, "N=%zu D=%zu I=%zu T=%zu %s\n", + col->nwidth, col->decimal, intsz, totsz, dp->string); return totsz; }