=================================================================== RCS file: /cvs/mandoc/read.c,v retrieving revision 1.146 retrieving revision 1.149 diff -u -p -r1.146 -r1.149 --- mandoc/read.c 2015/11/07 14:22:29 1.146 +++ mandoc/read.c 2016/07/10 13:34:30 1.149 @@ -1,7 +1,7 @@ -/* $Id: read.c,v 1.146 2015/11/07 14:22:29 schwarze Exp $ */ +/* $Id: read.c,v 1.149 2016/07/10 13:34:30 schwarze Exp $ */ /* * Copyright (c) 2008, 2009, 2010, 2011 Kristaps Dzonsons - * Copyright (c) 2010-2015 Ingo Schwarze + * Copyright (c) 2010-2016 Ingo Schwarze * Copyright (c) 2010, 2012 Joerg Sonnenberger * * Permission to use, copy, modify, and distribute this software for any @@ -539,9 +539,9 @@ rerun: if (curp->secondary) curp->secondary->sz -= pos + 1; save_file = curp->file; - if (mparse_open(curp, &fd, ln.buf + of) == - MANDOCLEVEL_OK) { + if ((fd = mparse_open(curp, ln.buf + of)) != -1) { mparse_readfd(curp, fd, ln.buf + of); + close(fd); curp->file = save_file; } else { curp->file = save_file; @@ -773,17 +773,14 @@ mparse_readfd(struct mparse *curp, int fd, const char #endif free(blk.buf); } - - if (fd != STDIN_FILENO && close(fd) == -1) - perror(file); - return curp->file_status; } -enum mandoclevel -mparse_open(struct mparse *curp, int *fd, const char *file) +int +mparse_open(struct mparse *curp, const char *file) { char *cp; + int fd; curp->file = file; cp = strrchr(file, '.'); @@ -791,8 +788,8 @@ mparse_open(struct mparse *curp, int *fd, const char * /* First try to use the filename as it is. */ - if ((*fd = open(file, O_RDONLY)) != -1) - return MANDOCLEVEL_OK; + if ((fd = open(file, O_RDONLY)) != -1) + return fd; /* * If that doesn't work and the filename doesn't @@ -801,18 +798,18 @@ mparse_open(struct mparse *curp, int *fd, const char * if ( ! curp->gzip) { mandoc_asprintf(&cp, "%s.gz", file); - *fd = open(file, O_RDONLY); + fd = open(cp, O_RDONLY); free(cp); - if (*fd != -1) { + if (fd != -1) { curp->gzip = 1; - return MANDOCLEVEL_OK; + return fd; } } /* Neither worked, give up. */ mandoc_msg(MANDOCERR_FILE, curp, 0, 0, strerror(errno)); - return MANDOCLEVEL_ERROR; + return -1; } struct mparse *