=================================================================== RCS file: /cvs/mandoc/term.c,v retrieving revision 1.111 retrieving revision 1.116 diff -u -p -r1.111 -r1.116 --- mandoc/term.c 2009/10/26 07:18:23 1.111 +++ mandoc/term.c 2009/10/28 06:54:12 1.116 @@ -1,4 +1,4 @@ -/* $Id: term.c,v 1.111 2009/10/26 07:18:23 kristaps Exp $ */ +/* $Id: term.c,v 1.116 2009/10/28 06:54:12 kristaps Exp $ */ /* * Copyright (c) 2008, 2009 Kristaps Dzonsons * @@ -19,6 +19,7 @@ #include #include #include +#include #include "chars.h" #include "out.h" @@ -76,9 +77,8 @@ term_alloc(enum termenc enc) { struct termp *p; - if (NULL == (p = malloc(sizeof(struct termp)))) + if (NULL == (p = calloc(1, sizeof(struct termp)))) return(NULL); - bzero(p, sizeof(struct termp)); p->maxrmargin = 78; p->enc = enc; return(p); @@ -119,36 +119,42 @@ term_alloc(enum termenc enc) * If TERMP_NOBREAK is specified and the line overruns the right * margin, it will break and pad-right to the right margin after * writing. If maxrmargin is violated, it will break and continue - * writing from the right-margin, which will lead to the above - * scenario upon exit. - * - * Otherwise, the line will break at the right margin. Extremely long - * lines will cause the system to emit a warning (TODO: hyphenate, if - * possible). + * writing from the right-margin, which will lead to the above scenario + * upon exit. Otherwise, the line will break at the right margin. */ void term_flushln(struct termp *p) { - int i, j; - size_t vbl, vsz, vis, maxvis, mmax, bp; + int i; /* current input position in p->buf */ + size_t vis; /* current visual position on output */ + size_t vbl; /* number of blanks to prepend to output */ + size_t vsz; /* visual characters to write to output */ + size_t bp; /* visual right border position */ + int j; /* temporary loop index */ + size_t maxvis, mmax; static int overstep = 0; /* * First, establish the maximum columns of "visible" content. * This is usually the difference between the right-margin and * an indentation, but can be, for tagged lists or columns, a - * small set of values. + * small set of values. */ assert(p->offset < p->rmargin); - assert((int)(p->rmargin - p->offset) - overstep > 0); - maxvis = /* LINTED */ - p->rmargin - p->offset - overstep; - mmax = /* LINTED */ - p->maxrmargin - p->offset - overstep; + maxvis = (int)(p->rmargin - p->offset) - overstep < 0 ? + 0 : p->rmargin - p->offset - overstep; + mmax = (int)(p->maxrmargin - p->offset) - overstep < 0 ? + 0 : p->maxrmargin - p->offset - overstep; bp = TERMP_NOBREAK & p->flags ? mmax : maxvis; + + /* + * FIXME: if bp is zero, we still output the first word before + * breaking the line. + */ + vis = 0; /* @@ -204,7 +210,8 @@ term_flushln(struct termp *p) vis = 0; } /* Remove the overstep width. */ - bp += overstep; + bp += (int)/* LINTED */ + overstep; overstep = 0; } else { for (j = 0; j < (int)vbl; j++)